Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 3006993002: Delete Rtx-related methods from RTPPayloadRegistry. (Closed)

Created:
3 years, 3 months ago by nisse-webrtc
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, danilchap, yujie_mao (webrtc), zhuangzesen_agora.io, Andrew MacDonald, zhengzhonghou_agora.io, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, AleBzk, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete Rtx-related methods from RTPPayloadRegistry. Delete methods IsRtx, IsEncapsulated and RestoreOriginalPacket. BUG=webrtc:7135 Review-Url: https://codereview.webrtc.org/3006993002 Cr-Commit-Position: refs/heads/master@{#19739} Committed: https://chromium.googlesource.com/external/webrtc/+/5b4b52264132eefba10bc6880871715f9692da90

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Update RtpRtcpRtxNackTest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -304 lines) Patch
M webrtc/modules/rtp_rtcp/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h View 1 chunk +0 lines, -12 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/nack_rtx_unittest.cc View 1 2 15 chunks +56 lines, -110 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry.cc View 3 chunks +0 lines, -60 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_payload_registry_unittest.cc View 2 chunks +0 lines, -100 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M webrtc/video/rtp_video_stream_receiver.cc View 1 2 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
nisse-webrtc
This cl deletes the old code for doing RTX decapsulation. It's still unclear to me ...
3 years, 3 months ago (2017-09-07 13:09:11 UTC) #2
stefan-webrtc
lgtm
3 years, 3 months ago (2017-09-07 13:22:08 UTC) #3
danilchap
lgtm if all bots agree these functions are no longer used. "code under test" for ...
3 years, 3 months ago (2017-09-07 13:38:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006993002/40001
3 years, 3 months ago (2017-09-08 09:09:10 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/5b4b52264132eefba10bc6880871715f9692da90
3 years, 3 months ago (2017-09-08 09:12:02 UTC) #13
nisse-webrtc
3 years, 3 months ago (2017-09-08 12:00:37 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/3011093002/ by nisse@webrtc.org.

The reason for reverting is: This has to be reverted to enable reverting cl
https://codereview.webrtc.org/3006063002/, which seems to have broken ulpfec..

Powered by Google App Engine
This is Rietveld 408576698