Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 3011713002: In PC integration tests, create tracks/streams with random IDs. (Closed)

Created:
3 years, 3 months ago by Taylor Brandstetter
Modified:
3 years, 3 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

In PC integration tests, create tracks/streams with random IDs. Previously the helper methods (like "CreateLocalAudioTrack") were using hard-coded IDs. This means if you try to add two tracks to the same PeerConnection you'll get an ID conflict. Tests were getting around this by using APIs to explicitly add tracks with different IDs. But this leaks an implementation detail of the helper methods, and is a hassle. So instead, just use random UUIDs from the helper methods. This is how IDs are created in the real world, so it's pretty reasonable and allows the tests to be made more readable. BUG=None Review-Url: https://codereview.webrtc.org/3011713002 Cr-Commit-Position: refs/heads/master@{#19736} Committed: https://chromium.googlesource.com/external/webrtc/+/b1a15d7711ffd419acd7dea3d307bf22f33ecba3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -35 lines) Patch
M webrtc/pc/peerconnection_integrationtest.cc View 7 chunks +13 lines, -35 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Taylor Brandstetter
PTAL
3 years, 3 months ago (2017-08-31 18:13:02 UTC) #2
pthatcher1
lgtm
3 years, 3 months ago (2017-09-05 22:24:21 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 3007923002 Patch 1). Please resolve the dependency and ...
3 years, 3 months ago (2017-09-07 01:07:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3011713002/1
3 years, 3 months ago (2017-09-07 20:44:56 UTC) #8
commit-bot: I haz the power
3 years, 3 months ago (2017-09-07 21:12:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b1a15d7711ffd419acd7dea3d...

Powered by Google App Engine
This is Rietveld 408576698