In PC integration tests, create tracks/streams with random IDs.

In PC integration tests, create tracks/streams with random IDs.

Previously the helper methods (like "CreateLocalAudioTrack") were using
hard-coded IDs. This means if you try to add two tracks to the same
PeerConnection you'll get an ID conflict. Tests were getting around
this by using APIs to explicitly add tracks with different IDs. But
this leaks an implementation detail of the helper methods, and is a
hassle.

So instead, just use random UUIDs from the helper methods. This is how
IDs are created in the real world, so it's pretty reasonable and allows
the tests to be made more readable.

BUG=None

Review-Url: https://codereview.webrtc.org/3011713002
Cr-Commit-Position: refs/heads/master@{#19736}
Committed: https://chromium.googlesource.com/external/webrtc/+/b1a15d7711ffd419acd7dea3d307bf22f33ecba3

[Taylor Brandstetter, 2017-08-31 18:13:01]

deadbeef@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[Taylor Brandstetter, 2017-08-31 18:13:02]

PTAL

[pthatcher1, 2017-09-05 22:24:21]

lgtm

[Taylor Brandstetter, 2017-09-07 01:07:49]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-09-07 01:07:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-07 01:07:56]

This CL has an open dependency (Issue 3007923002 Patch 1). Please resolve the
dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Taylor Brandstetter, 2017-09-07 20:44:42]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2017-09-07 20:44:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-07 21:12:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1504817082232280, "parent_rev":
"fed36f7fa96525f5e995fe5c4935b3619c8b7344", "commit_rev":
"b1a15d7711ffd419acd7dea3d307bf22f33ecba3"}

[commit-bot: I haz the power, 2017-09-07 21:12:11]

Description was changed from

==========
In PC integration tests, create tracks/streams with random IDs.

Previously the helper methods (like "CreateLocalAudioTrack") were using
hard-coded IDs. This means if you try to add two tracks to the same
PeerConnection you'll get an ID conflict. Tests were getting around
this by using APIs to explicitly add tracks with different IDs. But
this leaks an implementation detail of the helper methods, and is a
hassle.

So instead, just use random UUIDs from the helper methods. This is how
IDs are created in the real world, so it's pretty reasonable and allows
the tests to be made more readable.

BUG=None
==========

to

==========
In PC integration tests, create tracks/streams with random IDs.

Previously the helper methods (like "CreateLocalAudioTrack") were using
hard-coded IDs. This means if you try to add two tracks to the same
PeerConnection you'll get an ID conflict. Tests were getting around
this by using APIs to explicitly add tracks with different IDs. But
this leaks an implementation detail of the helper methods, and is a
hassle.

So instead, just use random UUIDs from the helper methods. This is how
IDs are created in the real world, so it's pretty reasonable and allows
the tests to be made more readable.

BUG=None

Review-Url: https://codereview.webrtc.org/3011713002
Cr-Commit-Position: refs/heads/master@{#19736}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b1a15d7711ffd419acd7dea3d...
==========

[commit-bot: I haz the power, 2017-09-07 21:12:13]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b1a15d7711ffd419acd7dea3d...