Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 3007923002: Add a PeerConnection integration test for adding an audio track mid-call (Closed)

Created:
3 years, 3 months ago by Taylor Brandstetter
Modified:
3 years, 3 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add a PeerConnection integration test for adding an audio track mid-call BUG=None Review-Url: https://codereview.webrtc.org/3007923002 Cr-Commit-Position: refs/heads/master@{#19731} Committed: https://chromium.googlesource.com/external/webrtc/+/4389b4d96bb98cf210b761b4f152434fceb767a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M webrtc/pc/peerconnection_integrationtest.cc View 2 chunks +25 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
Taylor Brandstetter
PTAL
3 years, 3 months ago (2017-08-31 18:03:25 UTC) #2
pthatcher1
lgtm
3 years, 3 months ago (2017-09-05 22:10:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3007923002/1
3 years, 3 months ago (2017-09-07 01:35:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/27956) linux_tsan2 on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 3 months ago (2017-09-07 01:43:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3007923002/1
3 years, 3 months ago (2017-09-07 15:42:24 UTC) #11
commit-bot: I haz the power
3 years, 3 months ago (2017-09-07 16:07:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/4389b4d96bb98cf210b761b4f...

Powered by Google App Engine
This is Rietveld 408576698