Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 3011413002: Remove remaining mentions of gflags (Closed)

Created:
3 years, 2 months ago by oprypin_webrtc
Modified:
3 years, 2 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove remaining mentions of gflags BUG=webrtc:7644 Review-Url: https://codereview.webrtc.org/3011413002 Cr-Commit-Position: refs/heads/master@{#19950} Committed: https://webrtc.googlesource.com/src/+/fbbba3f771e732ac8de43499060a584c1c0e7a90

Patch Set 1 : Original change https://webrtc-review.googlesource.com/2687 #

Patch Set 2 : Replace `!build_with_chromium` with `rtc_include_tests` #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -16 lines) Patch
M .gn View 1 chunk +4 lines, -0 lines 0 comments Download
M DEPS View 2 chunks +0 lines, -5 lines 0 comments Download
M rtc_tools/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M test/BUILD.gn View 1 2 chunks +2 lines, -4 lines 0 comments Download
M tools_webrtc/autoroller/roll_deps.py View 1 chunk +0 lines, -1 line 0 comments Download
M tools_webrtc/autoroller/unittests/roll_deps_test.py View 1 chunk +1 line, -1 line 0 comments Download
M tools_webrtc/autoroller/unittests/testdata/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
oprypin_webrtc
I see that I can't just remove `!build_with_chromium`, because test_main uses logging methods that are ...
3 years, 2 months ago (2017-09-25 13:52:56 UTC) #5
kjellander_webrtc
lgtm
3 years, 2 months ago (2017-09-25 14:10:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3011413002/20001
3 years, 2 months ago (2017-09-25 15:31:40 UTC) #10
commit-bot: I haz the power
3 years, 2 months ago (2017-09-25 15:34:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://webrtc.googlesource.com/src/+/fbbba3f771e732ac8de43499060a584c1c0e7a90

Powered by Google App Engine
This is Rietveld 408576698