Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/BUILD.gn

Issue 3011413002: Remove remaining mentions of gflags (Closed)
Patch Set: Replace `!build_with_chromium` with `rtc_include_tests` Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « rtc_tools/BUILD.gn ('k') | tools_webrtc/autoroller/roll_deps.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/BUILD.gn
diff --git a/test/BUILD.gn b/test/BUILD.gn
index 36f353930782df8ce2040701ea44629a11c13644..07c79d56e6a93bc304b65b1ee230ebfaccc0d879 100644
--- a/test/BUILD.gn
+++ b/test/BUILD.gn
@@ -27,7 +27,7 @@ group("test") {
":video_test_common",
]
- if (!build_with_chromium) {
+ if (rtc_include_tests) {
deps += [
":test_main",
":test_support_unittests",
@@ -175,9 +175,7 @@ rtc_source_set("test_support") {
}
}
-if (!build_with_chromium) {
- # This target used to depend on //third_party/gflags which Chromium does not
- # provide. TODO(oprypin): remove the conditional.
+if (rtc_include_tests) {
rtc_source_set("test_main") {
testonly = true
sources = [
« no previous file with comments | « rtc_tools/BUILD.gn ('k') | tools_webrtc/autoroller/roll_deps.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698