Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 3011193002: Removed the timeout for the delay estimate quality. (Closed)

Created:
3 years, 3 months ago by peah-webrtc
Modified:
3 years, 3 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed the timeout for the delay estimate quality. BUG=webrtc:8223, chromium:763761 Review-Url: https://codereview.webrtc.org/3011193002 Cr-Commit-Position: refs/heads/master@{#19773} Committed: https://chromium.googlesource.com/external/webrtc/+/c6b1041d6782ca3a483ac72f42c85375230a48c8

Patch Set 1 #

Patch Set 2 : Fixed unit tests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M webrtc/modules/audio_processing/aec3/render_delay_controller.cc View 3 chunks +3 lines, -5 lines 2 comments Download
M webrtc/modules/audio_processing/aec3/render_delay_controller_unittest.cc View 1 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
peah-webrtc
Hi ivoc@ Could you please take a look at this fairly small CL? https://codereview.webrtc.org/3011193002/diff/20001/webrtc/modules/audio_processing/aec3/render_delay_controller.cc File ...
3 years, 3 months ago (2017-09-11 12:31:42 UTC) #9
peah-webrtc
ivoc@ Could you please take a look at this small CL?
3 years, 3 months ago (2017-09-11 13:04:19 UTC) #11
ivoc
lgtm.
3 years, 3 months ago (2017-09-11 13:37:06 UTC) #12
ivoc
lgtm.
3 years, 3 months ago (2017-09-11 13:40:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3011193002/20001
3 years, 3 months ago (2017-09-11 13:41:49 UTC) #15
commit-bot: I haz the power
3 years, 3 months ago (2017-09-11 13:46:13 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/c6b1041d6782ca3a483ac72f4...

Powered by Google App Engine
This is Rietveld 408576698