Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: webrtc/modules/audio_processing/aec3/render_delay_controller_unittest.cc

Issue 3011193002: Removed the timeout for the delay estimate quality. (Closed)
Patch Set: Fixed unit tests Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_processing/aec3/render_delay_controller_unittest.cc
diff --git a/webrtc/modules/audio_processing/aec3/render_delay_controller_unittest.cc b/webrtc/modules/audio_processing/aec3/render_delay_controller_unittest.cc
index ba2f25bc72cef41abb0cdd299d51483acece42d1..45d00f9fd76792ecf1553ce917ad47529292fc4d 100644
--- a/webrtc/modules/audio_processing/aec3/render_delay_controller_unittest.cc
+++ b/webrtc/modules/audio_processing/aec3/render_delay_controller_unittest.cc
@@ -53,8 +53,9 @@ TEST(RenderDelayController, NoRenderSignal) {
RenderDelayController::Create(AudioProcessing::Config::EchoCanceller3(),
rate));
for (size_t k = 0; k < 100; ++k) {
- EXPECT_EQ(0u, delay_controller->GetDelay(
- delay_buffer->GetDownsampledRenderBuffer(), block));
+ EXPECT_EQ(kMinEchoPathDelayBlocks,
+ delay_controller->GetDelay(
+ delay_buffer->GetDownsampledRenderBuffer(), block));
}
}
}
@@ -78,7 +79,7 @@ TEST(RenderDelayController, BasicApiCalls) {
render_delay_buffer->GetDownsampledRenderBuffer(), capture_block);
}
EXPECT_FALSE(delay_controller->AlignmentHeadroomSamples());
- EXPECT_EQ(0u, delay_blocks);
+ EXPECT_EQ(kMinEchoPathDelayBlocks, delay_blocks);
}
}
@@ -113,9 +114,6 @@ TEST(RenderDelayController, Alignment) {
size_t expected_delay_blocks =
std::max(0, static_cast<int>(delay_samples / kBlockSize) -
kDelayHeadroomBlocks);
- if (expected_delay_blocks < 2) {
- expected_delay_blocks = 0;
- }
EXPECT_EQ(expected_delay_blocks, delay_blocks);

Powered by Google App Engine
This is Rietveld 408576698