Remove the support of fallback from DTLS to SDES.

Remove the support of fallback from DTLS to SDES.

The support of fallback from DTLS to SDES is removed in this CL.
Setting an SDP with both DTLS fingerprint and SDES crypto would fail.

BUG=webrtc:8266
Review-Url: https://codereview.webrtc.org/3011133002
Cr-Commit-Position: refs/heads/master@{#19903}
Committed: https://webrtc.googlesource.com/src/+/b19012e6cce70380135e20e29a6631b0ab14f48d

[Zhi Huang, 2017-09-08 20:52:53]

Patchset #2 (id:20001) has been deleted

[Zhi Huang, 2017-09-08 20:55:21]

The CQ bit was checked by zhihuang@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-08 20:55:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[Zhi Huang, 2017-09-08 20:59:46]

zhihuang@webrtc.org changed reviewers:
+ deadbeef@webrtc.org

[Zhi Huang, 2017-09-08 20:59:46]

PTAL.

[commit-bot: I haz the power, 2017-09-08 21:22:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-08 21:22:19]

Dry run: This issue passed the CQ dry run.

[Taylor Brandstetter, 2017-09-11 20:31:16]

lgtm with nits. Also, can you create a bug entry?

https://codereview.webrtc.org/3011133002/diff/1/webrtc/pc/peerconnectioninter...
File webrtc/pc/peerconnectioninterface_unittest.cc (right):

https://codereview.webrtc.org/3011133002/diff/1/webrtc/pc/peerconnectioninter...
webrtc/pc/peerconnectioninterface_unittest.cc:2251: // Test that fallback from
DTLS to SDES is not supported.
Can you mention in the comment that this functionality was previously supported,
but was removed in order to simplify the code and because it's non-standard?

https://codereview.webrtc.org/3011133002/diff/1/webrtc/pc/peerconnectioninter...
webrtc/pc/peerconnectioninterface_unittest.cc:2252:
TEST_F(PeerConnectionInterfaceTest, DtlsSdesFallbackNotSupport) {
nit: "NotSupported" instead of "NotSupport"

[Zhi Huang, 2017-09-19 18:48:40]

Description was changed from

==========
Remove the support of fallback from DTLS to SDES.

The support of fallback from DTLS to SDES is removed in this CL.
Setting an SDP with both DTLS fingerprint and SDES crypto would fail.

BUG=None.
==========

to

==========
Remove the support of fallback from DTLS to SDES.

The support of fallback from DTLS to SDES is removed in this CL.
Setting an SDP with both DTLS fingerprint and SDES crypto would fail.

BUG=webrtc:8266
==========

[Zhi Huang, 2017-09-19 20:20:43]

Patchset #2 (id:40001) has been deleted

[Zhi Huang, 2017-09-19 20:21:24]

The CQ bit was checked by zhihuang@webrtc.org

[Zhi Huang, 2017-09-19 20:21:25]

The patchset sent to the CQ was uploaded after l-g-t-m from deadbeef@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3011133002/#ps60001 (title:
"Merge and address the comments.")

[commit-bot: I haz the power, 2017-09-19 20:21:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-19 20:48:00]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1505852484804810,
"parent_rev": "b335e31bcb16f53883c7d205daf25f0dc1fe2662", "commit_rev":
"b19012e6cce70380135e20e29a6631b0ab14f48d"}

[commit-bot: I haz the power, 2017-09-19 20:48:05]

Description was changed from

==========
Remove the support of fallback from DTLS to SDES.

The support of fallback from DTLS to SDES is removed in this CL.
Setting an SDP with both DTLS fingerprint and SDES crypto would fail.

BUG=webrtc:8266
==========

to

==========
Remove the support of fallback from DTLS to SDES.

The support of fallback from DTLS to SDES is removed in this CL.
Setting an SDP with both DTLS fingerprint and SDES crypto would fail.

BUG=webrtc:8266

Review-Url: https://codereview.webrtc.org/3011133002
Cr-Commit-Position: refs/heads/master@{#19903}
Committed:
https://webrtc.googlesource.com/src/+/b19012e6cce70380135e20e29a6631b0ab14f48d
==========

[commit-bot: I haz the power, 2017-09-19 20:48:05]

Committed patchset #2 (id:60001) as
https://webrtc.googlesource.com/src/+/b19012e6cce70380135e20e29a6631b0ab14f48d