Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: p2p/base/transportdescriptionfactory.cc

Issue 3011133002: Remove the support of fallback from DTLS to SDES. (Closed)
Patch Set: Merge and address the comments. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « p2p/base/transportcontroller.cc ('k') | pc/peerconnectioninterface_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2012 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 } 112 }
113 113
114 // This digest algorithm is used to produce the a=fingerprint lines in SDP. 114 // This digest algorithm is used to produce the a=fingerprint lines in SDP.
115 // RFC 4572 Section 5 requires that those lines use the same hash function as 115 // RFC 4572 Section 5 requires that those lines use the same hash function as
116 // the certificate's signature, which is what CreateFromCertificate does. 116 // the certificate's signature, which is what CreateFromCertificate does.
117 desc->identity_fingerprint.reset( 117 desc->identity_fingerprint.reset(
118 rtc::SSLFingerprint::CreateFromCertificate(certificate_)); 118 rtc::SSLFingerprint::CreateFromCertificate(certificate_));
119 if (!desc->identity_fingerprint) { 119 if (!desc->identity_fingerprint) {
120 return false; 120 return false;
121 } 121 }
122 std::string digest_alg;
123 if (!certificate_->ssl_certificate().GetSignatureDigestAlgorithm(
124 &digest_alg)) {
125 LOG(LS_ERROR) << "Failed to retrieve the certificate's digest algorithm";
126 return false;
127 }
128
129 desc->identity_fingerprint.reset(
130 rtc::SSLFingerprint::Create(digest_alg, certificate_->identity()));
131 if (!desc->identity_fingerprint.get()) {
132 LOG(LS_ERROR) << "Failed to create identity fingerprint, alg="
133 << digest_alg;
134 return false;
135 }
136 122
137 // Assign security role. 123 // Assign security role.
138 desc->connection_role = role; 124 desc->connection_role = role;
139 return true; 125 return true;
140 } 126 }
141 127
142 } // namespace cricket 128 } // namespace cricket
OLDNEW
« no previous file with comments | « p2p/base/transportcontroller.cc ('k') | pc/peerconnectioninterface_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698