Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 3010413002: Total Harmonic Distorsion plus noise (THD+n) score in APM-QA. (Closed)

Created:
3 years, 3 months ago by AleBzk
Modified:
3 years, 2 months ago
Reviewers:
aleloi
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Total Harmonic Distorsion plus noise (THD+n) score in APM-QA. In order to compute a THD score, a pure tone must be used as input signal. Also, its frequency must be known. For this reason, this CL adds a number of changes in the APM-QA pipeline. More in detail, input signal metadata is loaded and passed to the THD evaluation score instance. This makes the eval_scores module less reusable, but it is fine since the module has been specifically designed for the APM-QA module. BUG=webrtc:7494 Review-Url: https://codereview.webrtc.org/3010413002 Cr-Commit-Position: refs/heads/master@{#19970} Committed: https://webrtc.googlesource.com/src/+/5d26edcc02ac7545a0d73155eb92922cd2451a0f

Patch Set 1 #

Patch Set 2 : README how to run unittests #

Patch Set 3 : merge #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -39 lines) Patch
M modules/audio_processing/test/py_quality_assessment/README.md View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M modules/audio_processing/test/py_quality_assessment/quality_assessment/data_access.py View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M modules/audio_processing/test/py_quality_assessment/quality_assessment/eval_scores.py View 1 2 5 chunks +99 lines, -2 lines 0 comments Download
M modules/audio_processing/test/py_quality_assessment/quality_assessment/eval_scores_unittest.py View 1 2 3 chunks +47 lines, -1 line 0 comments Download
M modules/audio_processing/test/py_quality_assessment/quality_assessment/evaluation.py View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M modules/audio_processing/test/py_quality_assessment/quality_assessment/exceptions.py View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M modules/audio_processing/test/py_quality_assessment/quality_assessment/input_signal_creator.py View 1 2 1 chunk +18 lines, -8 lines 0 comments Download
M modules/audio_processing/test/py_quality_assessment/quality_assessment/signal_processing.py View 1 2 2 chunks +8 lines, -7 lines 0 comments Download
M modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation.py View 1 2 3 chunks +34 lines, -17 lines 0 comments Download
M modules/audio_processing/test/py_quality_assessment/quality_assessment/simulation_unittest.py View 1 2 4 chunks +40 lines, -1 line 0 comments Download
M modules/audio_processing/test/py_quality_assessment/quality_assessment/test_data_generation.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (10 generated)
AleBzk
Hi Alex, As discussed offline, this CL comes from https://chromium-review.googlesource.com/c/external/webrtc/+/609840/. It contains all the changes ...
3 years, 3 months ago (2017-09-14 12:56:59 UTC) #3
aleloi
lgtm
3 years, 3 months ago (2017-09-14 12:59:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3010413002/60001
3 years, 2 months ago (2017-09-26 12:23:27 UTC) #11
commit-bot: I haz the power
3 years, 2 months ago (2017-09-26 12:53:26 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://webrtc.googlesource.com/src/+/5d26edcc02ac7545a0d73155eb92922cd2451a0f

Powered by Google App Engine
This is Rietveld 408576698