Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: modules/audio_processing/test/py_quality_assessment/quality_assessment/input_signal_creator.py

Issue 3010413002: Total Harmonic Distorsion plus noise (THD+n) score in APM-QA. (Closed)
Patch Set: merge Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: modules/audio_processing/test/py_quality_assessment/quality_assessment/input_signal_creator.py
diff --git a/modules/audio_processing/test/py_quality_assessment/quality_assessment/input_signal_creator.py b/modules/audio_processing/test/py_quality_assessment/quality_assessment/input_signal_creator.py
index e2a720c796f58d21c4ec0fcb217390cbbdeac64a..5d97c3b2fc102c2689ae8f1a606540f7c88f0f8a 100644
--- a/modules/audio_processing/test/py_quality_assessment/quality_assessment/input_signal_creator.py
+++ b/modules/audio_processing/test/py_quality_assessment/quality_assessment/input_signal_creator.py
@@ -18,26 +18,36 @@ class InputSignalCreator(object):
"""
@classmethod
- def Create(cls, name, params):
- """Creates a input signal.
+ def Create(cls, name, raw_params):
+ """Creates a input signal and its metadata.
Args:
name: Input signal creator name.
- params: Tuple of parameters to pass to the specific signal creator.
+ raw_params: Tuple of parameters to pass to the specific signal creator.
Returns:
- AudioSegment instance.
+ (AudioSegment, dict) tuple.
"""
try:
+ signal = {}
+ params = {}
+
if name == 'pure_tone':
- return cls._CreatePureTone(float(params[0]), int(params[1]))
+ params['frequency'] = float(raw_params[0])
+ params['duration'] = int(raw_params[1])
+ signal = cls._CreatePureTone(params['frequency'], params['duration'])
+ else:
+ raise exceptions.InputSignalCreatorException(
+ 'Invalid input signal creator name')
+
+ # Complete metadata.
+ params['signal'] = name
+
+ return signal, params
except (TypeError, AssertionError) as e:
raise exceptions.InputSignalCreatorException(
'Invalid signal creator parameters: {}'.format(e))
- raise exceptions.InputSignalCreatorException(
- 'Invalid input signal creator name')
-
@classmethod
def _CreatePureTone(cls, frequency, duration):
"""

Powered by Google App Engine
This is Rietveld 408576698