Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 3010223002: Update thread annotiation macros in modules to use RTC_ prefix (Closed)

Created:
3 years, 3 months ago by danilchap
Modified:
3 years, 3 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, AleBzk, peah-webrtc, zhuangzesen_agora.io, henrika_webrtc, aleloi, Andrew MacDonald, stefan-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, sdk-team_agora.io, kwiberg-webrtc, minyue-webrtc, the sun, mflodman, zhengzhonghou_agora.io, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update thread annotiation macros in modules to use RTC_ prefix BUG=webrtc:8198 Review-Url: https://codereview.webrtc.org/3010223002 Cr-Commit-Position: refs/heads/master@{#19728} Committed: https://chromium.googlesource.com/external/webrtc/+/56359be7fea745a29a47d3a36b99016e6dbd2741

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+908 lines, -867 lines) Patch
M webrtc/modules/audio_coding/acm2/acm_receiver.h View 1 chunk +10 lines, -10 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module.cc View 3 chunks +27 lines, -24 lines 0 comments Download
M webrtc/modules/audio_coding/acm2/audio_coding_module_unittest.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/locked_bandwidth_info.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 5 chunks +85 lines, -77 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_buffer.h View 2 chunks +20 lines, -20 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_ios.h View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_device_alsa_linux.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_device_pulse_linux.h View 1 chunk +150 lines, -147 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_device_pulse_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_mixer/audio_mixer_impl.h View 3 chunks +7 lines, -6 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/echo_canceller3.h View 2 chunks +12 lines, -10 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.h View 8 chunks +56 lines, -55 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl_locking_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/echo_cancellation_impl.h View 1 chunk +11 lines, -11 lines 0 comments Download
M webrtc/modules/audio_processing/echo_control_mobile_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/gain_control_impl.h View 1 chunk +12 lines, -12 lines 0 comments Download
M webrtc/modules/audio_processing/level_estimator_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/noise_suppression_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/voice_detection_impl.h View 1 chunk +8 lines, -8 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.h View 2 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/congestion_controller/include/receive_side_congestion_controller.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/include/send_side_congestion_controller.h View 2 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/congestion_controller/probe_controller.h View 1 chunk +20 lines, -19 lines 0 comments Download
M webrtc/modules/congestion_controller/transport_feedback_adapter.h View 1 chunk +8 lines, -7 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.h View 1 chunk +18 lines, -18 lines 0 comments Download
M webrtc/modules/pacing/packet_router.h View 1 chunk +13 lines, -13 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h View 2 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h View 1 chunk +9 lines, -9 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h View 2 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/flexfec_receiver.h View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_payload_registry.h View 1 chunk +4 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/playout_delay_oracle.h View 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 2 chunks +35 lines, -34 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 2 chunks +54 lines, -51 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_header_parser.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_packet_history.h View 1 chunk +8 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 4 chunks +29 lines, -27 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h View 2 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.h View 4 chunks +14 lines, -14 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264_decoder_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/video_codec_test.h View 1 chunk +6 lines, -4 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 2 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/frame_buffer2.h View 1 chunk +22 lines, -22 lines 0 comments Download
M webrtc/modules/video_coding/generic_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_coding/generic_encoder.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/jitter_buffer.h View 4 chunks +28 lines, -27 lines 0 comments Download
M webrtc/modules/video_coding/media_optimization.h View 1 chunk +19 lines, -17 lines 0 comments Download
M webrtc/modules/video_coding/nack_module.h View 2 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/video_coding/packet_buffer.h View 2 chunks +17 lines, -15 lines 0 comments Download
M webrtc/modules/video_coding/protection_bitrate_calculator.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/rtp_frame_reference_finder.h View 3 chunks +31 lines, -28 lines 0 comments Download
M webrtc/modules/video_coding/timing.h View 1 chunk +18 lines, -18 lines 0 comments Download
M webrtc/modules/video_coding/utility/quality_scaler.h View 1 chunk +6 lines, -6 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 4 chunks +17 lines, -15 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
danilchap
This CL generated with the script #!/bin/sh MACROS=(GUARDED_BY GUARDED_VAR PT_GUARDED_BY PT_GUARDED_VAR ACQUIRED_AFTER ACQUIRED_BEFORE EXCLUSIVE_LOCKS_REQUIRED SHARED_LOCKS_REQUIRED ...
3 years, 3 months ago (2017-09-07 08:01:41 UTC) #4
kwiberg-webrtc
lgtm, provided that the CL consists entirely of the automated changes you described---if there were ...
3 years, 3 months ago (2017-09-07 14:43:11 UTC) #7
danilchap
On 2017/09/07 14:43:11, kwiberg-webrtc wrote: > lgtm, provided that the CL consists entirely of the ...
3 years, 3 months ago (2017-09-07 14:50:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3010223002/1
3 years, 3 months ago (2017-09-07 14:51:14 UTC) #10
commit-bot: I haz the power
3 years, 3 months ago (2017-09-07 14:53:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/56359be7fea745a29a47d3a36...

Powered by Google App Engine
This is Rietveld 408576698