webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h - Issue 3010223002: Update thread annotiation macros in modules to use RTC_ prefix

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h

Issue 3010223002: Update thread annotiation macros in modules to use RTC_ prefix (Closed)

Patch Set: Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/pacing/packet_router.h ('k') | webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h

diff --git a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h

index 564b563cc7de8c9b60bfde30123fea25ee0d3746..135e4480672c4ef34cb61d87a8c9b7098a4dcefb 100644

--- a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h

+++ b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h

@@ -106,12 +106,13 @@ class RemoteBitrateEstimatorAbsSendTime : public RemoteBitrateEstimator {

const std::list<Cluster>& clusters) const;

// Returns true if a probe which changed the estimate was detected.

- ProbeResult ProcessClusters(int64_t now_ms) EXCLUSIVE_LOCKS_REQUIRED(&crit_);

+ ProbeResult ProcessClusters(int64_t now_ms)

+ RTC_EXCLUSIVE_LOCKS_REQUIRED(&crit_);

bool IsBitrateImproving(int probe_bitrate_bps) const

- EXCLUSIVE_LOCKS_REQUIRED(&crit_);

+ RTC_EXCLUSIVE_LOCKS_REQUIRED(&crit_);

- void TimeoutStreams(int64_t now_ms) EXCLUSIVE_LOCKS_REQUIRED(&crit_);

+ void TimeoutStreams(int64_t now_ms) RTC_EXCLUSIVE_LOCKS_REQUIRED(&crit_);

rtc::ThreadChecker network_thread_;

const Clock* const clock_;

@@ -130,8 +131,8 @@ class RemoteBitrateEstimatorAbsSendTime : public RemoteBitrateEstimator {

bool uma_recorded_;

rtc::CriticalSection crit_;

- Ssrcs ssrcs_ GUARDED_BY(&crit_);

- AimdRateControl remote_rate_ GUARDED_BY(&crit_);

+ Ssrcs ssrcs_ RTC_GUARDED_BY(&crit_);

+ AimdRateControl remote_rate_ RTC_GUARDED_BY(&crit_);

RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(RemoteBitrateEstimatorAbsSendTime);

};