Improves stereo/mono audio support on Android

Improves stereo/mono audio support on Android.

Fixes some issues related to calling WebRtcAudioManager.setStereoOutput(true)
and WebRtcAudioManager.setStereoInput(true) and ensures that the ADM reports
correct values related to stereo support given these settings.

Also makes it more clear that the OpenSLES audio implementation does not support
stereo (we now fail in Init()).

To summarize: this change ensures that the user can ask for stereo input
and/or stereo output audio on Android in combination with the Java based 
audio layer. By default (if no WebRtcAudioManager.setStereoXXX() APIs are called), mono will be used.

BUG=webrtc:7962
Review-Url: https://codereview.webrtc.org/3009193002
Cr-Commit-Position: refs/heads/master@{#19763}
Committed: https://chromium.googlesource.com/external/webrtc/+/76535de14fa3d823b30f015d76b535887699dc8f

[henrika_webrtc, 2017-09-07 13:16:33]

Description was changed from

==========
Improves stereo/mono audio support on Android

Improves stereo/mono audio support on Android

BUG=
==========

to

==========
Improves stereo/mono audio support on Android

BUG=webrtc:7962
==========

[henrika_webrtc, 2017-09-07 13:26:21]

Description was changed from

==========
Improves stereo/mono audio support on Android

BUG=webrtc:7962
==========

to

==========
Improves stereo/mono audio support on Android.

Fixes some issues related to calling WebRtcAudioManager.setStereoOutput(true)
and WebRtcAudioManager.setStereoInput(true) and ensures that the ADM reports
correct values related to stereo support given these settings.

Also makes it more clear that the OpenSLES audio implementation does not support
stereo (we noe fail in Init()).

To summarize: this change ensures that the user can ask for stereo input
and/or stereo output audio on Android in combination with the Java based 
audio layer. By default (if no WebRtcAudioManager.setStereoXXX() APIs are
called), mono will be used.

BUG=webrtc:7962
==========

[henrika_webrtc, 2017-09-07 13:27:02]

The CQ bit was checked by henrika@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-07 13:27:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[henrika_webrtc, 2017-09-07 13:32:42]

henrika@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org

[henrika_webrtc, 2017-09-07 13:46:28]

Description was changed from

==========
Improves stereo/mono audio support on Android.

Fixes some issues related to calling WebRtcAudioManager.setStereoOutput(true)
and WebRtcAudioManager.setStereoInput(true) and ensures that the ADM reports
correct values related to stereo support given these settings.

Also makes it more clear that the OpenSLES audio implementation does not support
stereo (we noe fail in Init()).

To summarize: this change ensures that the user can ask for stereo input
and/or stereo output audio on Android in combination with the Java based 
audio layer. By default (if no WebRtcAudioManager.setStereoXXX() APIs are
called), mono will be used.

BUG=webrtc:7962
==========

to

==========
Improves stereo/mono audio support on Android.

Fixes some issues related to calling WebRtcAudioManager.setStereoOutput(true)
and WebRtcAudioManager.setStereoInput(true) and ensures that the ADM reports
correct values related to stereo support given these settings.

Also makes it more clear that the OpenSLES audio implementation does not support
stereo (we now fail in Init()).

To summarize: this change ensures that the user can ask for stereo input
and/or stereo output audio on Android in combination with the Java based 
audio layer. By default (if no WebRtcAudioManager.setStereoXXX() APIs are
called), mono will be used.

BUG=webrtc:7962
==========

[henrika_webrtc, 2017-09-07 14:27:08]

FYI: linux_memcheck trybot seems flaky. Not related to this CL.

[henrika_webrtc, 2017-09-07 14:45:31]

The CQ bit was checked by henrika@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-07 14:45:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-07 15:21:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-07 15:21:45]

Dry run: This issue passed the CQ dry run.

[hlundin-webrtc, 2017-09-11 07:43:42]

LGTM % typos

https://codereview.webrtc.org/3009193002/diff/20001/webrtc/modules/audio_devi...
File webrtc/modules/audio_device/android/audio_device_template.h (right):

https://codereview.webrtc.org/3009193002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/audio_device_template.h:346: // Instead, the
native audio layer is configured via the aduio manager
Typo: aduio -> audio

https://codereview.webrtc.org/3009193002/diff/20001/webrtc/modules/audio_devi...
webrtc/modules/audio_device/android/audio_device_template.h:367: // Instead, the
native audio layer is configured via the aduio manager
Typo: aduio -> audio

[henrika_webrtc, 2017-09-11 07:55:54]

The CQ bit was checked by henrika@webrtc.org

[henrika_webrtc, 2017-09-11 07:55:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrik.lundin@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3009193002/#ps40001 (title:
"nit")

[commit-bot: I haz the power, 2017-09-11 07:56:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-11 08:25:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1505116554896550,
"parent_rev": "1ddfc5502a67c0728aaa909f3b9848f832a27cb2", "commit_rev":
"76535de14fa3d823b30f015d76b535887699dc8f"}

[commit-bot: I haz the power, 2017-09-11 08:26:00]

Description was changed from

==========
Improves stereo/mono audio support on Android.

Fixes some issues related to calling WebRtcAudioManager.setStereoOutput(true)
and WebRtcAudioManager.setStereoInput(true) and ensures that the ADM reports
correct values related to stereo support given these settings.

Also makes it more clear that the OpenSLES audio implementation does not support
stereo (we now fail in Init()).

To summarize: this change ensures that the user can ask for stereo input
and/or stereo output audio on Android in combination with the Java based 
audio layer. By default (if no WebRtcAudioManager.setStereoXXX() APIs are
called), mono will be used.

BUG=webrtc:7962
==========

to

==========
Improves stereo/mono audio support on Android.

Fixes some issues related to calling WebRtcAudioManager.setStereoOutput(true)
and WebRtcAudioManager.setStereoInput(true) and ensures that the ADM reports
correct values related to stereo support given these settings.

Also makes it more clear that the OpenSLES audio implementation does not support
stereo (we now fail in Init()).

To summarize: this change ensures that the user can ask for stereo input
and/or stereo output audio on Android in combination with the Java based 
audio layer. By default (if no WebRtcAudioManager.setStereoXXX() APIs are
called), mono will be used.

BUG=webrtc:7962

Review-Url: https://codereview.webrtc.org/3009193002
Cr-Commit-Position: refs/heads/master@{#19763}
Committed:
https://chromium.googlesource.com/external/webrtc/+/76535de14fa3d823b30f015d7...
==========

[commit-bot: I haz the power, 2017-09-11 08:26:01]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/76535de14fa3d823b30f015d7...