Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: webrtc/modules/audio_device/android/opensles_player.cc

Issue 3009193002: Improves stereo/mono audio support on Android (Closed)
Patch Set: nit Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_device/android/opensles_player.cc
diff --git a/webrtc/modules/audio_device/android/opensles_player.cc b/webrtc/modules/audio_device/android/opensles_player.cc
index 513f8233f855e050152a2a36189df82036be7282..3a40bf477992698795e58cbd3957b87b3fa5a41c 100644
--- a/webrtc/modules/audio_device/android/opensles_player.cc
+++ b/webrtc/modules/audio_device/android/opensles_player.cc
@@ -79,6 +79,11 @@ OpenSLESPlayer::~OpenSLESPlayer() {
int OpenSLESPlayer::Init() {
ALOGD("Init%s", GetThreadInfo().c_str());
RTC_DCHECK(thread_checker_.CalledOnValidThread());
+ if (audio_parameters_.channels() == 2) {
+ // TODO(henrika): FineAudioBuffer needs more work to support stereo.
+ ALOGE("OpenSLESPlayer does not support stereo");
+ return -1;
+ }
return 0;
}

Powered by Google App Engine
This is Rietveld 408576698