Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 3008913002: Split up VideoProcessorIntegrationTest files. (Closed)

Created:
3 years, 3 months ago by brandtr
Modified:
3 years, 3 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Split up VideoProcessorIntegrationTest files. Changes made: * VideoProcessorIntegrationTest definition goes in .h file. * Member function definitions go into .cc file. * Tests move to _libvpx.cc and _openh264.cc files. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/3008913002 Cr-Commit-Position: refs/heads/master@{#19637} Committed: https://chromium.googlesource.com/external/webrtc/+/12a47f696544a99c168902d87cc19dd286b6784b

Patch Set 1 #

Patch Set 2 : Mini-improvements. #

Patch Set 3 : Fix compile. #

Total comments: 2

Patch Set 4 : asapersson comments 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+731 lines, -1013 lines) Patch
M webrtc/modules/video_coding/BUILD.gn View 3 chunks +8 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 2 6 chunks +52 lines, -616 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 1 2 chunks +601 lines, -367 lines 0 comments Download
A + webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_libvpx.cc View 2 chunks +1 line, -29 lines 0 comments Download
A webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_openh264.cc View 1 2 3 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
brandtr
Please take a look :)
3 years, 3 months ago (2017-08-31 10:27:39 UTC) #3
åsapersson
lgtm https://codereview.webrtc.org/3008913002/diff/40001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_openh264.cc File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_openh264.cc (right): https://codereview.webrtc.org/3008913002/diff/40001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_openh264.cc#newcode35 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_openh264.cc:35: const int kNumFramesShort = 100; maybe kNumFrames
3 years, 3 months ago (2017-08-31 15:28:19 UTC) #4
brandtr
https://codereview.webrtc.org/3008913002/diff/40001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_openh264.cc File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_openh264.cc (right): https://codereview.webrtc.org/3008913002/diff/40001/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_openh264.cc#newcode35 webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_openh264.cc:35: const int kNumFramesShort = 100; On 2017/08/31 15:28:19, åsapersson ...
3 years, 3 months ago (2017-08-31 15:34:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3008913002/50001
3 years, 3 months ago (2017-09-01 07:08:07 UTC) #12
commit-bot: I haz the power
3 years, 3 months ago (2017-09-01 07:10:38 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:50001) as
https://chromium.googlesource.com/external/webrtc/+/12a47f696544a99c168902d87...

Powered by Google App Engine
This is Rietveld 408576698