Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2666)

Unified Diff: webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_libvpx.cc

Issue 3008913002: Split up VideoProcessorIntegrationTest files. (Closed)
Patch Set: asapersson comments 1. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_libvpx.cc
diff --git a/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_libvpx.cc
similarity index 93%
copy from webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc
copy to webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_libvpx.cc
index 04609bf525cf45382e23b0ba0f5b65bfaea24ebf..062f662c179c2e9cf3ca7ea7d960c6c3a68045a5 100644
--- a/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc
+++ b/webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_libvpx.cc
@@ -39,35 +39,6 @@ const std::nullptr_t kNoVisualizationParams = nullptr;
} // namespace
-#if defined(WEBRTC_USE_H264)
-
-// H264: Run with no packet loss and fixed bitrate. Quality should be very high.
-// Note(hbos): The PacketManipulatorImpl code used to simulate packet loss in
-// these unittests appears to drop "packets" in a way that is not compatible
-// with H264. Therefore ProcessXPercentPacketLossH264, X != 0, unittests have
-// not been added.
-TEST_F(VideoProcessorIntegrationTest, Process0PercentPacketLossH264) {
- SetTestConfig(&config_, kHwCodec, kUseSingleCore, 0.0f, kForemanCif,
- kVerboseLogging);
- SetCodecSettings(&config_, kVideoCodecH264, 1, false, false, true, false,
- kResilienceOn, kCifWidth, kCifHeight);
-
- RateProfile rate_profile;
- SetRateProfile(&rate_profile, 0, 500, 30, 0);
- rate_profile.frame_index_rate_update[1] = kNumFramesShort + 1;
- rate_profile.num_frames = kNumFramesShort;
-
- std::vector<RateControlThresholds> rc_thresholds;
- AddRateControlThresholds(2, 60, 20, 10, 20, 0, 1, &rc_thresholds);
-
- QualityThresholds quality_thresholds(35.0, 25.0, 0.93, 0.70);
-
- ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds,
- kNoVisualizationParams);
-}
-
-#endif // defined(WEBRTC_USE_H264)
-
// Fails on iOS. See webrtc:4755.
#if !defined(WEBRTC_IOS)
@@ -412,5 +383,6 @@ TEST_F(VideoProcessorIntegrationTest, MAYBE_ProcessNoLossTemporalLayersVP8) {
ProcessFramesAndMaybeVerify(rate_profile, &rc_thresholds, &quality_thresholds,
kNoVisualizationParams);
}
+
} // namespace test
} // namespace webrtc

Powered by Google App Engine
This is Rietveld 408576698