rtc_task_queue should not expose rtc_base_approved API

Now that https://codereview.webrtc.org/3003643002 is landed we can
remove rtc_base_approved from the public_deps list of rtc_task_queue.

BUG=webrtc:8160
NOTRY=True

Review-Url: https://codereview.webrtc.org/3008553002
Cr-Commit-Position: refs/heads/master@{#19551}
Committed: https://chromium.googlesource.com/external/webrtc/+/95c8f65382fb537b8d03c50031367f9414b30156

[mbonadei, 2017-08-25 12:25:03]

Description was changed from

==========
task_queue should not expose rtc_base_approved API

BUG=None
==========

to

==========
task_queue should not expose rtc_base_approved API

BUG=webrtc:8160
==========

[mbonadei, 2017-08-25 12:29:39]

Description was changed from

==========
task_queue should not expose rtc_base_approved API

BUG=webrtc:8160
==========

to

==========
Now that https://codereview.webrtc.org/3003643002 is landed we can
remove rtc_base_approved from the public_deps list of rtc_task_queue.

BUG=webrtc:8160
==========

[mbonadei, 2017-08-25 12:37:42]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org, nisse@webrtc.org, perkj@webrtc.org

[nisse-webrtc, 2017-08-25 12:50:29]

I don't understand all the fine details, but it makes sense to me since nothing
else (but base and rtc_base) lists rtc_base_approved as a public dependency.
lgtm

[mbonadei, 2017-08-25 12:58:38]

On 2017/08/25 12:50:29, nisse-webrtc wrote:
> I don't understand all the fine details, but it makes sense to me since
nothing
> else (but base and rtc_base) lists rtc_base_approved as a public dependency.
> lgtm

Thanks, I can try to explain a little bit more...
If we keep rtc_base_approved in rtc_task_queue public_deps list a target X that
depends on rtc_task_queue can use rtc_base_approved headers without explicitly
depending on rtc_base_approved.

[mbonadei, 2017-08-25 13:00:17]

Description was changed from

==========
Now that https://codereview.webrtc.org/3003643002 is landed we can
remove rtc_base_approved from the public_deps list of rtc_task_queue.

BUG=webrtc:8160
==========

to

==========
Now that https://codereview.webrtc.org/3003643002 is landed we can
remove rtc_base_approved from the public_deps list of rtc_task_queue.

BUG=webrtc:8160
NOTRY=True
==========

[kjellander_webrtc, 2017-08-25 13:00:43]

lgtm

[mbonadei, 2017-08-25 14:28:10]

The failure on linux_chromium_rel_ng seems unrelated to this change.

[kwiberg-webrtc, 2017-08-27 23:02:13]

kwiberg@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[kwiberg-webrtc, 2017-08-27 23:02:14]

lgtm!

[mbonadei, 2017-08-28 06:37:54]

The CQ bit was checked by mbonadei@webrtc.org

[commit-bot: I haz the power, 2017-08-28 06:37:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-28 06:40:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1503902274875380, "parent_rev":
"2fff9d2c4b8da1b958e6d3097e7e020ac1bb6c60", "commit_rev":
"95c8f65382fb537b8d03c50031367f9414b30156"}

[commit-bot: I haz the power, 2017-08-28 06:40:15]

Description was changed from

==========
Now that https://codereview.webrtc.org/3003643002 is landed we can
remove rtc_base_approved from the public_deps list of rtc_task_queue.

BUG=webrtc:8160
NOTRY=True
==========

to

==========
Now that https://codereview.webrtc.org/3003643002 is landed we can
remove rtc_base_approved from the public_deps list of rtc_task_queue.

BUG=webrtc:8160
NOTRY=True

Review-Url: https://codereview.webrtc.org/3008553002
Cr-Commit-Position: refs/heads/master@{#19551}
Committed:
https://chromium.googlesource.com/external/webrtc/+/95c8f65382fb537b8d03c5003...
==========

[commit-bot: I haz the power, 2017-08-28 06:40:16]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/95c8f65382fb537b8d03c5003...