Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: webrtc/rtc_base/BUILD.gn

Issue 3008553002: rtc_task_queue should not expose rtc_base_approved API (Closed)
Patch Set: Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/utility/BUILD.gn ('k') | webrtc/rtc_tools/network_tester/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("//build/config/crypto.gni") 9 import("//build/config/crypto.gni")
10 import("//build/config/ui.gni") 10 import("//build/config/ui.gni")
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
289 if (is_nacl) { 289 if (is_nacl) {
290 deps += [ "//native_client_sdk/src/libraries/nacl_io" ] 290 deps += [ "//native_client_sdk/src/libraries/nacl_io" ]
291 } 291 }
292 } 292 }
293 293
294 config("enable_libevent_config") { 294 config("enable_libevent_config") {
295 defines = [ "WEBRTC_BUILD_LIBEVENT" ] 295 defines = [ "WEBRTC_BUILD_LIBEVENT" ]
296 } 296 }
297 297
298 rtc_source_set("rtc_task_queue") { 298 rtc_source_set("rtc_task_queue") {
299 deps = [
300 ":rtc_base_approved",
301 ]
299 public_deps = [ 302 public_deps = [
300 ":rtc_base_approved",
301 ":rtc_task_queue_api", 303 ":rtc_task_queue_api",
302 ] 304 ]
303 305
304 if (rtc_link_task_queue_impl) { 306 if (rtc_link_task_queue_impl) {
305 deps = [ 307 deps += [ ":rtc_task_queue_impl" ]
306 ":rtc_task_queue_impl",
307 ]
308 } 308 }
309 } 309 }
310 310
311 # WebRTC targets must not directly depend on rtc_task_queue_api or 311 # WebRTC targets must not directly depend on rtc_task_queue_api or
312 # rtc_task_queue_impl. Instead, depend on rtc_task_queue. 312 # rtc_task_queue_impl. Instead, depend on rtc_task_queue.
313 # The build flag |rtc_link_task_queue_impl| decides if WebRTC targets will link 313 # The build flag |rtc_link_task_queue_impl| decides if WebRTC targets will link
314 # to the default implemenation in rtc_task_queue_impl or if an externally 314 # to the default implemenation in rtc_task_queue_impl or if an externally
315 # provided implementation should be used. An external implementation should 315 # provided implementation should be used. An external implementation should
316 # depend on rtc_task_queue_api. 316 # depend on rtc_task_queue_api.
317 rtc_source_set("rtc_task_queue_api") { 317 rtc_source_set("rtc_task_queue_api") {
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 } 365 }
366 } 366 }
367 367
368 rtc_static_library("sequenced_task_checker") { 368 rtc_static_library("sequenced_task_checker") {
369 sources = [ 369 sources = [
370 "sequenced_task_checker.h", 370 "sequenced_task_checker.h",
371 "sequenced_task_checker_impl.cc", 371 "sequenced_task_checker_impl.cc",
372 "sequenced_task_checker_impl.h", 372 "sequenced_task_checker_impl.h",
373 ] 373 ]
374 deps = [ 374 deps = [
375 ":rtc_base_approved",
375 ":rtc_task_queue", 376 ":rtc_task_queue",
376 ] 377 ]
377 } 378 }
378 379
379 rtc_static_library("weak_ptr") { 380 rtc_static_library("weak_ptr") {
380 sources = [ 381 sources = [
381 "weak_ptr.cc", 382 "weak_ptr.cc",
382 "weak_ptr.h", 383 "weak_ptr.h",
383 ] 384 ]
384 deps = [ 385 deps = [
(...skipping 513 matching lines...) Expand 10 before | Expand all | Expand 10 after
898 # gets additional generated targets which would require many lines here to 899 # gets additional generated targets which would require many lines here to
899 # cover (which would be confusing to read and hard to maintain). 900 # cover (which would be confusing to read and hard to maintain).
900 if (!is_android && !is_ios) { 901 if (!is_android && !is_ios) {
901 # TODO(kjellander): Reenable after finishing https://bugs.webrtc.org/7634. 902 # TODO(kjellander): Reenable after finishing https://bugs.webrtc.org/7634.
902 #visibility = [ "..:rtc_unittests" ] 903 #visibility = [ "..:rtc_unittests" ]
903 } 904 }
904 sources = [ 905 sources = [
905 "task_queue_unittest.cc", 906 "task_queue_unittest.cc",
906 ] 907 ]
907 deps = [ 908 deps = [
909 ":rtc_base_approved",
908 ":rtc_base_tests_main", 910 ":rtc_base_tests_main",
909 ":rtc_base_tests_utils", 911 ":rtc_base_tests_utils",
910 ":rtc_task_queue", 912 ":rtc_task_queue",
911 "../test:test_support", 913 "../test:test_support",
912 ] 914 ]
913 if (!build_with_chromium && is_clang) { 915 if (!build_with_chromium && is_clang) {
914 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 916 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
915 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 917 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
916 } 918 }
917 } 919 }
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
1060 if (is_android) { 1062 if (is_android) {
1061 android_library("base_java") { 1063 android_library("base_java") {
1062 java_files = [ 1064 java_files = [
1063 "java/src/org/webrtc/ContextUtils.java", 1065 "java/src/org/webrtc/ContextUtils.java",
1064 "java/src/org/webrtc/Logging.java", 1066 "java/src/org/webrtc/Logging.java",
1065 "java/src/org/webrtc/Size.java", 1067 "java/src/org/webrtc/Size.java",
1066 "java/src/org/webrtc/ThreadUtils.java", 1068 "java/src/org/webrtc/ThreadUtils.java",
1067 ] 1069 ]
1068 } 1070 }
1069 } 1071 }
OLDNEW
« no previous file with comments | « webrtc/modules/utility/BUILD.gn ('k') | webrtc/rtc_tools/network_tester/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698