Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 3008343002: WebRTC: Save logcat output to isolated outputs. (Closed)

Created:
3 years, 3 months ago by ehmaldonado_webrtc
Modified:
3 years, 3 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

WebRTC: Save logcat output to isolated outputs. NOTRY=True BUG=chromium:717417 Review-Url: https://codereview.webrtc.org/3008343002 Cr-Commit-Position: refs/heads/master@{#19748} Committed: https://chromium.googlesource.com/external/webrtc/+/34623ce83ad40fe5fa29c044f5839b51b1064f55

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M tools_webrtc/mb/mb.py View 1 chunk +4 lines, -1 line 0 comments Download
M tools_webrtc/mb/mb_unittest.py View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
ehmaldonado_webrtc
e.g. https://isolateserver.appspot.com/browse?namespace=default-gzip&hash=a66f3893ead8af17b2f67fda0b61d15477310ad8
3 years, 3 months ago (2017-09-08 13:26:24 UTC) #4
kjellander_webrtc
woho! lgtm but please check the android trybots so this is actually producing what we ...
3 years, 3 months ago (2017-09-08 13:35:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3008343002/1
3 years, 3 months ago (2017-09-08 14:00:12 UTC) #9
ehmaldonado_webrtc
On 2017/09/08 13:35:08, kjellander_webrtc wrote: > woho! lgtm > > but please check the android ...
3 years, 3 months ago (2017-09-08 14:00:17 UTC) #10
commit-bot: I haz the power
3 years, 3 months ago (2017-09-08 14:03:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/34623ce83ad40fe5fa29c044f...

Powered by Google App Engine
This is Rietveld 408576698