tools_webrtc/mb/mb.py - Issue 3008343002: WebRTC: Save logcat output to isolated outputs. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(290)

My Issues | Starred Open | Closed | All

Unified Diff: tools_webrtc/mb/mb.py

Issue 3008343002: WebRTC: Save logcat output to isolated outputs. (Closed)

Patch Set: Created 3 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | tools_webrtc/mb/mb_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools_webrtc/mb/mb.py

diff --git a/tools_webrtc/mb/mb.py b/tools_webrtc/mb/mb.py

index 9c92c2824edf30467c008607bcc470133ab237b4..8e57d39cb5dd775f10301c0ddb2e2c503b1e5570 100755

--- a/tools_webrtc/mb/mb.py

+++ b/tools_webrtc/mb/mb.py

@@ -1057,7 +1057,10 @@ class MetaBuildWrapper(object):

if android:

cmdline = ['../../build/android/test_wrapper/logdog_wrapper.py',

'--target', target,

- '--logdog-bin-cmd', '../../bin/logdog_butler']

+ '--logdog-bin-cmd', '../../bin/logdog_butler',

+ '--logcat-output-file', '${ISOLATED_OUTDIR}/logcats',

+ '--store-tombstones']

+

if test_type != 'junit_test':

cmdline += ['--target-devices-file', '${SWARMING_BOT_FILE}']

else:

« no previous file with comments | « no previous file | tools_webrtc/mb/mb_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698