Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1219)

Issue 3007973002: Mark template class RefCountedObject as final.

Created:
3 years ago by nisse-webrtc
Modified:
2 years, 12 months ago
Reviewers:
tommi, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, the sun, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Mark template class RefCountedObject as final. RefCountedObject should only ever be used as a leaf class in the inheritance tree. With final, the compiler can identify places where this template is used incorrectly; this cl tries to fix them all. BUG=webrtc:8270

Patch Set 1 #

Patch Set 2 : Rebased. #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -113 lines) Patch
M api/test/mock_rtpreceiver.h View 1 1 chunk +1 line, -1 line 0 comments Download
M api/test/mock_rtpsender.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ortc/ortcrtpreceiveradapter.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M ortc/ortcrtpsenderadapter.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M pc/peerconnection.cc View 1 7 chunks +22 lines, -13 lines 0 comments Download
M pc/quicdatachannel.h View 1 1 chunk +1 line, -1 line 0 comments Download
M pc/rtcstatscollector_unittest.cc View 1 12 chunks +19 lines, -19 lines 0 comments Download
M pc/rtpreceiver.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pc/rtpreceiver.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pc/rtpsender.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M pc/rtpsenderreceiver_unittest.cc View 1 10 chunks +22 lines, -15 lines 3 comments Download
M pc/statscollector_unittest.cc View 1 27 chunks +32 lines, -31 lines 0 comments Download
M pc/test/mock_datachannel.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M pc/test/mock_peerconnection.h View 1 2 chunks +5 lines, -7 lines 0 comments Download
M pc/webrtcsession_unittest.cc View 1 5 chunks +8 lines, -7 lines 0 comments Download
M rtc_base/refcountedobject.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
nisse-webrtc
When working on cl https://codereview.webrtc.org/3010883002/, we noticed that RefCountedObject is used incorrectly in a couple ...
3 years ago (2017-09-01 12:51:24 UTC) #2
tommi
On 2017/09/01 12:51:24, nisse-webrtc wrote: > When working on cl https://codereview.webrtc.org/3010883002/, we noticed that > ...
3 years ago (2017-09-01 14:57:28 UTC) #3
kwiberg-webrtc
lgtm!
3 years ago (2017-09-03 01:47:55 UTC) #4
nisse-webrtc
On 2017/09/01 14:57:28, tommi wrote: > Thumbs up on fixing this. Are the bot errors ...
3 years ago (2017-09-04 07:31:37 UTC) #5
nisse-webrtc
Downstream projects hopefully fixed by now. https://codereview.webrtc.org/3007973002/diff/20001/pc/rtpsenderreceiver_unittest.cc File pc/rtpsenderreceiver_unittest.cc (right): https://codereview.webrtc.org/3007973002/diff/20001/pc/rtpsenderreceiver_unittest.cc#newcode137 pc/rtpsenderreceiver_unittest.cc:137: std::vector<std::string>({local_stream_->label()}), The compiler ...
3 years ago (2017-09-18 08:28:57 UTC) #6
kwiberg-webrtc
https://codereview.webrtc.org/3007973002/diff/20001/pc/rtpsenderreceiver_unittest.cc File pc/rtpsenderreceiver_unittest.cc (right): https://codereview.webrtc.org/3007973002/diff/20001/pc/rtpsenderreceiver_unittest.cc#newcode137 pc/rtpsenderreceiver_unittest.cc:137: std::vector<std::string>({local_stream_->label()}), On 2017/09/18 08:28:57, nisse-webrtc wrote: > The compiler ...
3 years ago (2017-09-18 09:13:51 UTC) #7
nisse-webrtc
https://codereview.webrtc.org/3007973002/diff/20001/pc/rtpsenderreceiver_unittest.cc File pc/rtpsenderreceiver_unittest.cc (right): https://codereview.webrtc.org/3007973002/diff/20001/pc/rtpsenderreceiver_unittest.cc#newcode137 pc/rtpsenderreceiver_unittest.cc:137: std::vector<std::string>({local_stream_->label()}), On 2017/09/18 09:13:50, kwiberg-webrtc wrote: > On 2017/09/18 ...
3 years ago (2017-09-18 09:20:05 UTC) #8
nisse-webrtc
Another set of downstream fixes are now landed. I'd like to get this landed, as ...
2 years, 12 months ago (2017-09-22 07:41:00 UTC) #14
kwiberg-webrtc
On 2017/09/22 07:41:00, nisse-webrtc wrote: > Another set of downstream fixes are now landed. I'd ...
2 years, 12 months ago (2017-09-22 08:37:18 UTC) #15
kwiberg-webrtc
On 2017/09/22 08:37:18, kwiberg-webrtc wrote: > On 2017/09/22 07:41:00, nisse-webrtc wrote: > > Another set ...
2 years, 12 months ago (2017-09-22 08:38:28 UTC) #16
nisse-webrtc
2 years, 12 months ago (2017-09-22 09:28:04 UTC) #17
On 2017/09/22 08:38:28, kwiberg-webrtc wrote:
> On 2017/09/22 08:37:18, kwiberg-webrtc wrote:
> > On 2017/09/22 07:41:00, nisse-webrtc wrote:
> > > Another set of downstream fixes are now landed. I'd like to get this
landed,
> > as
> > > soon as the linux_internal bot is green.
> > 
> > stgm
> 
> Sorry, that should've been "gtmis" (good to me, it sounds). Accidental Yoda
> speech is hard to get right...

Discussed offline. Current plan is to land RefCountedBase first, so that
application code with concrete refcounted classes can be fixed to use that
instead of RefCountedObject.

Powered by Google App Engine
This is Rietveld 408576698