Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: pc/webrtcsession_unittest.cc

Issue 3007973002: Mark template class RefCountedObject as final.
Patch Set: Rebased. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pc/webrtcsession_unittest.cc
diff --git a/pc/webrtcsession_unittest.cc b/pc/webrtcsession_unittest.cc
index fe0049d33ac70de7f1e319123eba2b281ff3eae9..f389c9e4d644792ca1a607866acff180aef3c020 100644
--- a/pc/webrtcsession_unittest.cc
+++ b/pc/webrtcsession_unittest.cc
@@ -309,7 +309,7 @@ class WebRtcSessionForTest : public webrtc::WebRtcSession {
};
class WebRtcSessionCreateSDPObserverForTest
- : public rtc::RefCountedObject<CreateSessionDescriptionObserver> {
+ : public CreateSessionDescriptionObserver {
public:
enum State {
kInit,
@@ -788,8 +788,8 @@ class WebRtcSessionTest
SessionDescriptionInterface* CreateOffer(
const PeerConnectionInterface::RTCOfferAnswerOptions options) {
- rtc::scoped_refptr<WebRtcSessionCreateSDPObserverForTest>
- observer = new WebRtcSessionCreateSDPObserverForTest();
+ rtc::scoped_refptr<WebRtcSessionCreateSDPObserverForTest> observer =
+ new rtc::RefCountedObject<WebRtcSessionCreateSDPObserverForTest>();
cricket::MediaSessionOptions session_options;
GetOptionsForOffer(options, &session_options);
session_->CreateOffer(observer, options, session_options);
@@ -801,8 +801,8 @@ class WebRtcSessionTest
SessionDescriptionInterface* CreateAnswer(
const cricket::MediaSessionOptions& options) {
- rtc::scoped_refptr<WebRtcSessionCreateSDPObserverForTest> observer
- = new WebRtcSessionCreateSDPObserverForTest();
+ rtc::scoped_refptr<WebRtcSessionCreateSDPObserverForTest> observer =
+ new rtc::RefCountedObject<WebRtcSessionCreateSDPObserverForTest>();
cricket::MediaSessionOptions session_options = options;
GetOptionsForAnswer(&session_options);
session_->CreateAnswer(observer, session_options);
@@ -1620,7 +1620,8 @@ class WebRtcSessionTest
rtc::scoped_refptr<WebRtcSessionCreateSDPObserverForTest>
observers[kNumber];
for (int i = 0; i < kNumber; ++i) {
- observers[i] = new WebRtcSessionCreateSDPObserverForTest();
+ observers[i] =
+ new rtc::RefCountedObject<WebRtcSessionCreateSDPObserverForTest>();
if (type == CreateSessionDescriptionRequest::kOffer) {
session_->CreateOffer(observers[i], options, offer_session_options);
} else {
@@ -4546,7 +4547,7 @@ TEST_F(WebRtcSessionTest, CreateOffersAndShutdown) {
cricket::MediaSessionOptions session_options;
GetOptionsForOffer(options, &session_options);
for (auto& o : observers) {
- o = new WebRtcSessionCreateSDPObserverForTest();
+ o = new rtc::RefCountedObject<WebRtcSessionCreateSDPObserverForTest>();
session_->CreateOffer(o, options, session_options);
}

Powered by Google App Engine
This is Rietveld 408576698