Move array_view.h to webrtc/api/

Move array_view.h to webrtc/api/

We use ArrayView in our public API, so its header should be in
webrtc/api/.

BUG=none

Review-Url: https://codereview.webrtc.org/3007763002
Cr-Commit-Position: refs/heads/master@{#19658}
Committed: https://chromium.googlesource.com/external/webrtc/+/529662a44c85cc336762231f1cf7a0c339d6b994

[kwiberg-webrtc, 2017-08-29 12:33:04]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-29 12:33:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-29 13:22:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-29 13:22:03]

Dry run: Try jobs failed on following builders:
  linux_libfuzzer_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_libfuzzer_rel/bui...)

[kwiberg-webrtc, 2017-08-31 13:23:37]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-31 13:23:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-31 13:52:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-31 13:52:36]

Dry run: This issue passed the CQ dry run.

[kwiberg-webrtc, 2017-08-31 17:36:33]

kwiberg@webrtc.org changed reviewers:
+ mbonadei@webrtc.org, nisse@webrtc.org

[kwiberg-webrtc, 2017-08-31 17:40:53]

Patchset #1 (id:1) has been deleted

[nisse-webrtc, 2017-09-01 07:07:45]

lgtm

https://codereview.webrtc.org/3007763002/diff/20001/webrtc/api/array_view.h
File webrtc/api/array_view.h (right):

https://codereview.webrtc.org/3007763002/diff/20001/webrtc/api/array_view.h#n...
webrtc/api/array_view.h:17: #include "webrtc/rtc_base/type_traits.h"
In a different cl, you preferred <type_traits>. But here we need additional
declarations from rtc_base/type_traits.h?

https://codereview.webrtc.org/3007763002/diff/20001/webrtc/api/array_view.h#n...
webrtc/api/array_view.h:21: // Many functions read from or write to arrays. The
obvious way to do this is
Maybe refer to related upcoming standard classes, std::string_view (or anything
which is even closer).

[mbonadei, 2017-09-01 08:08:34]

lgtm.

https://codereview.webrtc.org/3007763002/diff/20001/webrtc/api/BUILD.gn
File webrtc/api/BUILD.gn (right):

https://codereview.webrtc.org/3007763002/diff/20001/webrtc/api/BUILD.gn#newco...
webrtc/api/BUILD.gn:277: defines = [ "GTEST_RELATIVE_PATH" ]
I think we can avoid to define GTEST_RELATIVE_PATH because it is defined in the
public_config attribute of rtc_base:rtc_base_tests_utils and it gets inherited.

https://codereview.webrtc.org/3007763002/diff/20001/webrtc/api/BUILD.gn#newco...
webrtc/api/BUILD.gn:279: public_deps = [
Also //testing/gmock is listed in the public_deps attribute of
rtc_base:rtc_base_tests_utils so we can remove this (unless we want to be
explicit but in that case I think we can move it to deps and avoid to re-expose
it to targets that will depend on :rtc_api_unittests).

[kwiberg-webrtc, 2017-09-01 08:45:31]

https://codereview.webrtc.org/3007763002/diff/20001/webrtc/api/array_view.h
File webrtc/api/array_view.h (right):

https://codereview.webrtc.org/3007763002/diff/20001/webrtc/api/array_view.h#n...
webrtc/api/array_view.h:17: #include "webrtc/rtc_base/type_traits.h"
On 2017/09/01 07:07:44, nisse-webrtc wrote:
> In a different cl, you preferred <type_traits>. But here we need additional
> declarations from rtc_base/type_traits.h?

Yes. rtc_base/type_traits.h currently defines just two traits:

// Determines if the given class has zero-argument .data() and .size() methods
// whose return values are convertible to T* and size_t, respectively.
template <typename DS, typename T>
class HasDataAndSize;

// Determines if the given type is integral, or an enum that
// converts implicitly to an integral type.
template <typename T>
struct IsIntlike;

If you want them, include rtc_base/type_traits.h. If you want the std type
traits, include <type_traits>. (array_view.h, which wants both, appears to
erroneously omit the latter #include; I may as well fix that in this CL, since
the precommit thingy strong-armed me into adding the missing #include
<algorithm>.)

https://codereview.webrtc.org/3007763002/diff/20001/webrtc/api/array_view.h#n...
webrtc/api/array_view.h:21: // Many functions read from or write to arrays. The
obvious way to do this is
On 2017/09/01 07:07:44, nisse-webrtc wrote:
> Maybe refer to related upcoming standard classes, std::string_view (or
anything
> which is even closer).

Hmm. There's a proposal for adding it (under the name "span") to C++20, but I
don't think it's been accepted yet. It's also present in GSL---I could link to
that, I guess.

[kwiberg-webrtc, 2017-09-01 08:55:42]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-01 08:55:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[kwiberg-webrtc, 2017-09-01 08:58:03]

https://codereview.webrtc.org/3007763002/diff/20001/webrtc/api/BUILD.gn
File webrtc/api/BUILD.gn (right):

https://codereview.webrtc.org/3007763002/diff/20001/webrtc/api/BUILD.gn#newco...
webrtc/api/BUILD.gn:277: defines = [ "GTEST_RELATIVE_PATH" ]
On 2017/09/01 08:08:34, mbonadei wrote:
> I think we can avoid to define GTEST_RELATIVE_PATH because it is defined in
the
> public_config attribute of rtc_base:rtc_base_tests_utils and it gets
inherited.

Done.

https://codereview.webrtc.org/3007763002/diff/20001/webrtc/api/BUILD.gn#newco...
webrtc/api/BUILD.gn:279: public_deps = [
On 2017/09/01 08:08:34, mbonadei wrote:
> Also //testing/gmock is listed in the public_deps attribute of
> rtc_base:rtc_base_tests_utils so we can remove this (unless we want to be
> explicit but in that case I think we can move it to deps and avoid to
re-expose
> it to targets that will depend on :rtc_api_unittests).

Done.

[commit-bot: I haz the power, 2017-09-01 09:33:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-01 09:33:26]

Dry run: Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/27266)

[kwiberg-webrtc, 2017-09-03 02:59:55]

The CQ bit was checked by kwiberg@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-03 03:00:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-03 03:18:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-03 03:18:37]

Dry run: Try jobs failed on following builders:
  android_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/27347)

[kwiberg-webrtc, 2017-09-03 05:22:44]

The CQ bit was checked by kwiberg@webrtc.org

[kwiberg-webrtc, 2017-09-03 05:22:45]

The patchset sent to the CQ was uploaded after l-g-t-m from nisse@webrtc.org,
mbonadei@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3007763002/#ps60001 (title:
"rebase")

[commit-bot: I haz the power, 2017-09-03 05:22:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-03 05:32:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-03 05:32:26]

Try jobs failed on following builders:
  android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

[mbonadei, 2017-09-04 07:02:57]

> Try jobs failed on following builders:
>   android_arm64_rel on master.tryserver.webrtc (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.webrtc/builders/android_arm64_rel/build...)

This issue has not been caused by this change. It is blocking the whole CQ at
the moment. I am looking into this.

[kwiberg-webrtc, 2017-09-04 11:15:07]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2017-09-04 11:15:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-04 12:43:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1504523707407360,
"parent_rev": "2c7b7a633f6a6aef4467cc3b35a056a4dcc9d619", "commit_rev":
"529662a44c85cc336762231f1cf7a0c339d6b994"}

[commit-bot: I haz the power, 2017-09-04 12:43:22]

Description was changed from

==========
Move array_view.h to webrtc/api/

We use ArrayView in our public API, so its header should be in
webrtc/api/.

BUG=none
==========

to

==========
Move array_view.h to webrtc/api/

We use ArrayView in our public API, so its header should be in
webrtc/api/.

BUG=none

Review-Url: https://codereview.webrtc.org/3007763002
Cr-Commit-Position: refs/heads/master@{#19658}
Committed:
https://chromium.googlesource.com/external/webrtc/+/529662a44c85cc336762231f1...
==========

[commit-bot: I haz the power, 2017-09-04 12:43:24]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/529662a44c85cc336762231f1...