Move array_view.h to webrtc/api/

webrtc/api/BUILD.gn

 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../webrtc.gni")
 if (is_android) {
@@ skipping 179 matching lines @@
     deps += [ "$rtc_libyuv_dir" ]
     public_deps = [
       "$rtc_libyuv_dir",
     ]
   } else {
     # Need to add a directory normally exported by libyuv.
     include_dirs = [ "$rtc_libyuv_dir/include" ]
   }
 }
 
+rtc_source_set("array_view") {
+  sources = [
+    "array_view.h",
+  ]
+  deps = [
+    "../rtc_base:rtc_base_approved",
+  ]
+}
+
 rtc_source_set("libjingle_peerconnection_test_api") {
   testonly = true
   sources = [
     "test/fakeconstraints.h",
   ]
 
   public_deps = [
     ":libjingle_peerconnection_api",
   ]
 
@@ skipping 38 matching lines @@
   rtc_source_set("rtc_api_unittests") {
     testonly = true
 
     # Skip restricting visibility on mobile platforms since the tests on those
     # gets additional generated targets which would require many lines here to
     # cover (which would be confusing to read and hard to maintain).
     if (!is_android && !is_ios) {
       visibility = [ "..:rtc_unittests" ]
     }
     sources = [
+      "array_view_unittest.cc",
       "ortc/mediadescription_unittest.cc",
       "ortc/sessiondescription_unittest.cc",
       "rtcerror_unittest.cc",
     ]
 
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
+    defines = [ "GTEST_RELATIVE_PATH" ]

[mbonadei, 2017/09/01 08:08:34]

I think we can avoid to define GTEST_RELATIVE_PATH because it is defined in the
public_config attribute of rtc_base:rtc_base_tests_utils and it gets inherited.

[kwiberg-webrtc, 2017/09/01 08:58:02]

Done.

+
+    public_deps = [

[mbonadei, 2017/09/01 08:08:34]

Also //testing/gmock is listed in the public_deps attribute of
rtc_base:rtc_base_tests_utils so we can remove this (unless we want to be
explicit but in that case I think we can move it to deps and avoid to re-expose
it to targets that will depend on :rtc_api_unittests).

[kwiberg-webrtc, 2017/09/01 08:58:02]

Done.

+      "//testing/gmock",
+    ]
 
     deps = [
+      ":array_view",
       ":libjingle_peerconnection_api",
       ":ortc_api",
+      "../rtc_base:rtc_base_approved",
+      "../rtc_base:rtc_base_tests_utils",
       "../test:test_support",
     ]
   }
 }