Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: webrtc/api/BUILD.gn

Issue 3007763002: Move array_view.h to webrtc/api/ (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/api/array_view.h » ('j') | webrtc/api/array_view.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/BUILD.gn
diff --git a/webrtc/api/BUILD.gn b/webrtc/api/BUILD.gn
index 3d19f03649e37822dc5ec2ae9039b8c84da804f7..1980c29ca9d4c78374982b9d60f70abef399b47c 100644
--- a/webrtc/api/BUILD.gn
+++ b/webrtc/api/BUILD.gn
@@ -197,6 +197,15 @@ rtc_source_set("video_frame_api") {
}
}
+rtc_source_set("array_view") {
+ sources = [
+ "array_view.h",
+ ]
+ deps = [
+ "../rtc_base:rtc_base_approved",
+ ]
+}
+
rtc_source_set("libjingle_peerconnection_test_api") {
testonly = true
sources = [
@@ -255,6 +264,7 @@ if (rtc_include_tests) {
visibility = [ "..:rtc_unittests" ]
}
sources = [
+ "array_view_unittest.cc",
"ortc/mediadescription_unittest.cc",
"ortc/sessiondescription_unittest.cc",
"rtcerror_unittest.cc",
@@ -264,10 +274,18 @@ if (rtc_include_tests) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
+ defines = [ "GTEST_RELATIVE_PATH" ]
mbonadei 2017/09/01 08:08:34 I think we can avoid to define GTEST_RELATIVE_PATH
kwiberg-webrtc 2017/09/01 08:58:02 Done.
+
+ public_deps = [
mbonadei 2017/09/01 08:08:34 Also //testing/gmock is listed in the public_deps
kwiberg-webrtc 2017/09/01 08:58:02 Done.
+ "//testing/gmock",
+ ]
deps = [
+ ":array_view",
":libjingle_peerconnection_api",
":ortc_api",
+ "../rtc_base:rtc_base_approved",
+ "../rtc_base:rtc_base_tests_utils",
"../test:test_support",
]
}
« no previous file with comments | « no previous file | webrtc/api/array_view.h » ('j') | webrtc/api/array_view.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698