Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 3007363002: Remove definitions of thread annotation macros without RTC_ prefix (Closed)

Created:
3 years, 3 months ago by danilchap
Modified:
3 years, 3 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove definition of thread annotation macros without RTC_ prefix BUG=webrtc:8198 Review-Url: https://codereview.webrtc.org/3007363002 Cr-Commit-Position: refs/heads/master@{#19810} Committed: https://chromium.googlesource.com/external/webrtc/+/47791cf0f8400984c0e90229c756e404ba7eee4f

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -71 lines) Patch
M webrtc/media/engine/webrtcvideoengine.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/rtc_base/thread_annotations.h View 4 chunks +0 lines, -63 lines 0 comments Download
M webrtc/rtc_base/thread_checker.h View 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
danilchap
final CL on this bug (chromium was updated and slightly checked here it still compile)
3 years, 3 months ago (2017-09-11 09:00:49 UTC) #6
kwiberg-webrtc
lgtm, once you make all the bots go green
3 years, 3 months ago (2017-09-11 12:31:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3007363002/20001
3 years, 3 months ago (2017-09-13 08:22:45 UTC) #14
commit-bot: I haz the power
3 years, 3 months ago (2017-09-13 08:25:53 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/47791cf0f8400984c0e90229c...

Powered by Google App Engine
This is Rietveld 408576698