Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: webrtc/rtc_base/thread_checker.h

Issue 3007363002: Remove definitions of thread annotation macros without RTC_ prefix (Closed)
Patch Set: Rebase Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/rtc_base/thread_annotations.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 // Borrowed from Chromium's src/base/threading/thread_checker.h. 11 // Borrowed from Chromium's src/base/threading/thread_checker.h.
12 12
13 #ifndef WEBRTC_RTC_BASE_THREAD_CHECKER_H_ 13 #ifndef WEBRTC_RTC_BASE_THREAD_CHECKER_H_
14 #define WEBRTC_RTC_BASE_THREAD_CHECKER_H_ 14 #define WEBRTC_RTC_BASE_THREAD_CHECKER_H_
15 15
16 // Apart from debug builds, we also enable the thread checker in 16 // Apart from debug builds, we also enable the thread checker in
17 // builds with RTC_DCHECK_IS_ON so that trybots and waterfall bots 17 // builds with RTC_DCHECK_IS_ON so that trybots and waterfall bots
18 // with this define will get the same level of thread checking as 18 // with this define will get the same level of thread checking as
19 // debug bots. 19 // debug bots.
20 #define ENABLE_THREAD_CHECKER RTC_DCHECK_IS_ON 20 #define RTC_ENABLE_THREAD_CHECKER RTC_DCHECK_IS_ON
21 21
22 #include "webrtc/rtc_base/checks.h" 22 #include "webrtc/rtc_base/checks.h"
23 #include "webrtc/rtc_base/constructormagic.h" 23 #include "webrtc/rtc_base/constructormagic.h"
24 #include "webrtc/rtc_base/thread_annotations.h" 24 #include "webrtc/rtc_base/thread_annotations.h"
25 #include "webrtc/rtc_base/thread_checker_impl.h" 25 #include "webrtc/rtc_base/thread_checker_impl.h"
26 26
27 namespace rtc { 27 namespace rtc {
28 28
29 // Do nothing implementation, for use in release mode. 29 // Do nothing implementation, for use in release mode.
30 // 30 //
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 // void Foo() { 63 // void Foo() {
64 // RTC_DCHECK(thread_checker_.CalledOnValidThread()); 64 // RTC_DCHECK(thread_checker_.CalledOnValidThread());
65 // ... (do stuff) ... 65 // ... (do stuff) ...
66 // } 66 // }
67 // 67 //
68 // private: 68 // private:
69 // ThreadChecker thread_checker_; 69 // ThreadChecker thread_checker_;
70 // } 70 // }
71 // 71 //
72 // In Release mode, CalledOnValidThread will always return true. 72 // In Release mode, CalledOnValidThread will always return true.
73 #if ENABLE_THREAD_CHECKER 73 #if RTC_ENABLE_THREAD_CHECKER
74 class RTC_LOCKABLE ThreadChecker : public ThreadCheckerImpl {}; 74 class RTC_LOCKABLE ThreadChecker : public ThreadCheckerImpl {};
75 #else 75 #else
76 class RTC_LOCKABLE ThreadChecker : public ThreadCheckerDoNothing {}; 76 class RTC_LOCKABLE ThreadChecker : public ThreadCheckerDoNothing {};
77 #endif // ENABLE_THREAD_CHECKER 77 #endif // RTC_ENABLE_THREAD_CHECKER
78 78
79 #undef ENABLE_THREAD_CHECKER 79 #undef RTC_ENABLE_THREAD_CHECKER
80 80
81 namespace internal { 81 namespace internal {
82 class RTC_SCOPED_LOCKABLE AnnounceOnThread { 82 class RTC_SCOPED_LOCKABLE AnnounceOnThread {
83 public: 83 public:
84 template <typename ThreadLikeObject> 84 template <typename ThreadLikeObject>
85 explicit AnnounceOnThread(const ThreadLikeObject* thread_like_object) 85 explicit AnnounceOnThread(const ThreadLikeObject* thread_like_object)
86 RTC_EXCLUSIVE_LOCK_FUNCTION(thread_like_object) {} 86 RTC_EXCLUSIVE_LOCK_FUNCTION(thread_like_object) {}
87 ~AnnounceOnThread() RTC_UNLOCK_FUNCTION() {} 87 ~AnnounceOnThread() RTC_UNLOCK_FUNCTION() {}
88 88
89 template<typename ThreadLikeObject> 89 template<typename ThreadLikeObject>
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 // rtc::scoped_ref_ptr<Encoder> encoder = encoder_; 157 // rtc::scoped_ref_ptr<Encoder> encoder = encoder_;
158 // encoder_->Queue()->PostTask([encoder] { encoder->Encode(); }); 158 // encoder_->Queue()->PostTask([encoder] { encoder->Encode(); });
159 // } 159 // }
160 // 160 //
161 // private: 161 // private:
162 // rtc::scoped_ref_ptr<Encoder> encoder_; 162 // rtc::scoped_ref_ptr<Encoder> encoder_;
163 // } 163 // }
164 164
165 // Document if a variable/field is not shared and should be accessed from 165 // Document if a variable/field is not shared and should be accessed from
166 // same thread/task queue. 166 // same thread/task queue.
167 #define ACCESS_ON(x) RTC_THREAD_ANNOTATION_ATTRIBUTE__(guarded_by(x))
168 #define RTC_ACCESS_ON(x) RTC_THREAD_ANNOTATION_ATTRIBUTE__(guarded_by(x)) 167 #define RTC_ACCESS_ON(x) RTC_THREAD_ANNOTATION_ATTRIBUTE__(guarded_by(x))
169 168
170 // Document if a function expected to be called from same thread/task queue. 169 // Document if a function expected to be called from same thread/task queue.
171 #define RUN_ON(x) RTC_THREAD_ANNOTATION_ATTRIBUTE__(exclusive_locks_required(x))
172 #define RTC_RUN_ON(x) RTC_THREAD_ANNOTATION_ATTRIBUTE__(exclusive_locks_required (x)) 170 #define RTC_RUN_ON(x) RTC_THREAD_ANNOTATION_ATTRIBUTE__(exclusive_locks_required (x))
173 171
174 #define RTC_DCHECK_RUN_ON(thread_like_object) \ 172 #define RTC_DCHECK_RUN_ON(thread_like_object) \
175 rtc::internal::AnnounceOnThread thread_announcer(thread_like_object); \ 173 rtc::internal::AnnounceOnThread thread_announcer(thread_like_object); \
176 RTC_DCHECK(rtc::internal::AnnounceOnThread::IsCurrent(thread_like_object)) 174 RTC_DCHECK(rtc::internal::AnnounceOnThread::IsCurrent(thread_like_object))
177 175
178 #endif // WEBRTC_RTC_BASE_THREAD_CHECKER_H_ 176 #endif // WEBRTC_RTC_BASE_THREAD_CHECKER_H_
OLDNEW
« no previous file with comments | « webrtc/rtc_base/thread_annotations.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698