Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 3006683002: Reland of Verify sender ssrc when receiving rtcp target bitrate (Closed)

Created:
3 years, 3 months ago by sprang_webrtc
Modified:
3 years, 3 months ago
Reviewers:
Zhi Huang, danilchap
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Verify sender ssrc when receiving rtcp target bitrate (patchset #1 id:1 of https://codereview.webrtc.org/3005633002/ ) Reason for revert: Landed fix in upstream project. Original issue's description: > Revert of Verify sender ssrc when receiving rtcp target bitrate (patchset #3 id:40001 of https://codereview.webrtc.org/3000373002/ ) > > Reason for revert: > Might be the root cause of an internal test failure. > > Original issue's description: > > Verify sender ssrc when receiving rtcp target bitrate > > > > BUG=webrtc:8137 > > > > Review-Url: https://codereview.webrtc.org/3000373002 > > Cr-Commit-Position: refs/heads/master@{#19524} > > Committed: https://chromium.googlesource.com/external/webrtc/+/a7a4beb419612e16e781e143f9bc0c812e044f75 > > TBR=danilchap@webrtc.org,sprang@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:8137 > > Review-Url: https://codereview.webrtc.org/3005633002 > Cr-Commit-Position: refs/heads/master@{#19529} > Committed: https://chromium.googlesource.com/external/webrtc/+/95a64ca8aa3ab20692bf8fbb24c7ea7b72abb0a6 TBR=danilchap@webrtc.org,zhihuang@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:8137 Review-Url: https://codereview.webrtc.org/3006683002 Cr-Commit-Position: refs/heads/master@{#19557} Committed: https://chromium.googlesource.com/external/webrtc/+/b32aaf97bd73d16604e9e85221f2dbc4a9433e61

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sprang_webrtc
Created Reland of Verify sender ssrc when receiving rtcp target bitrate
3 years, 3 months ago (2017-08-28 12:15:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006683002/1
3 years, 3 months ago (2017-08-28 12:15:59 UTC) #3
danilchap
lgtm
3 years, 3 months ago (2017-08-28 12:22:37 UTC) #4
commit-bot: I haz the power
3 years, 3 months ago (2017-08-28 12:49:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/b32aaf97bd73d16604e9e8522...

Powered by Google App Engine
This is Rietveld 408576698