Verify sender ssrc when receiving rtcp target bitrate

Verify sender ssrc when receiving rtcp target bitrate

BUG=webrtc:8137
Review-Url: https://codereview.webrtc.org/3000373002
Cr-Commit-Position: refs/heads/master@{#19524}
Committed: https://chromium.googlesource.com/external/webrtc/+/a7a4beb419612e16e781e143f9bc0c812e044f75

[sprang_webrtc, 2017-08-23 10:28:14]

sprang@webrtc.org changed reviewers:
+ danilchap@webrtc.org

[danilchap, 2017-08-23 10:33:56]

lgtm

https://codereview.webrtc.org/3000373002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.h (right):

https://codereview.webrtc.org/3000373002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:169: uint32_t ssrc,
for consistency with HandleXrReceiveReferenceTime may be
put it as first parameter and name it sender_ssrc

https://codereview.webrtc.org/3000373002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc (right):

https://codereview.webrtc.org/3000373002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc:1228: // Wrong sender
ssrc, target bitrate should be discarded.
may be explicitly set wrong sender ssrc, e.g.
xr.SetSenderSsrc(kSenderSsrc + 1);

https://codereview.webrtc.org/3000373002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc:1238: .Times(1);
EXPECT_CALLs nearby omit Times(1)

[sprang_webrtc, 2017-08-23 10:38:11]

https://codereview.webrtc.org/3000373002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver.h (right):

https://codereview.webrtc.org/3000373002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver.h:169: uint32_t ssrc,
On 2017/08/23 10:33:55, danilchap wrote:
> for consistency with HandleXrReceiveReferenceTime may be
> put it as first parameter and name it sender_ssrc

Done.

https://codereview.webrtc.org/3000373002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc (right):

https://codereview.webrtc.org/3000373002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc:1228: // Wrong sender
ssrc, target bitrate should be discarded.
On 2017/08/23 10:33:55, danilchap wrote:
> may be explicitly set wrong sender ssrc, e.g.
> xr.SetSenderSsrc(kSenderSsrc + 1);

Done.

https://codereview.webrtc.org/3000373002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_receiver_unittest.cc:1238: .Times(1);
On 2017/08/23 10:33:55, danilchap wrote:
> EXPECT_CALLs nearby omit Times(1)

Done.

[sprang_webrtc, 2017-08-23 10:38:16]

The CQ bit was checked by sprang@webrtc.org

[sprang_webrtc, 2017-08-23 10:38:16]

The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3000373002/#ps20001 (title:
"Addressed comments")

[commit-bot: I haz the power, 2017-08-23 10:38:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-23 10:49:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-23 10:49:36]

Try jobs failed on following builders:
  linux_ubsan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/14911)

[sprang_webrtc, 2017-08-23 10:57:11]

The CQ bit was checked by sprang@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-23 10:57:15]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-23 11:06:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-23 11:06:10]

Dry run: Try jobs failed on following builders:
  linux_memcheck on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_memcheck/builds/1...)

[sprang_webrtc, 2017-08-25 14:15:32]

The CQ bit was checked by sprang@webrtc.org

[sprang_webrtc, 2017-08-25 14:15:33]

The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3000373002/#ps40001 (title:
"Set sender ssrc on other unit test as well")

[commit-bot: I haz the power, 2017-08-25 14:15:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-25 16:06:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1503670532878290,
"parent_rev": "cb2bbce4e1920c874c76dcfcc54d6c9922c4ea4d", "commit_rev":
"a7a4beb419612e16e781e143f9bc0c812e044f75"}

[commit-bot: I haz the power, 2017-08-25 16:06:22]

Description was changed from

==========
Verify sender ssrc when receiving rtcp target bitrate

BUG=webrtc:8137
==========

to

==========
Verify sender ssrc when receiving rtcp target bitrate

BUG=webrtc:8137

Review-Url: https://codereview.webrtc.org/3000373002
Cr-Commit-Position: refs/heads/master@{#19524}
Committed:
https://chromium.googlesource.com/external/webrtc/+/a7a4beb419612e16e781e143f...
==========

[commit-bot: I haz the power, 2017-08-25 16:06:23]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/a7a4beb419612e16e781e143f...

[Zhi Huang, 2017-08-25 19:59:34]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/3005633002/ by zhihuang@webrtc.org.

The reason for reverting is: Might be the root cause of an internal test
failure..