Add explicit copy constructors to RTPHeader and RTPHeaderExtension

Add explicit copy constructors to RTPHeader and RTPHeaderExtension

Explicit copy-constructors are required by chromium. (No copy constructors were used until now, but a different CL requires them.)

BUG=None
TBR=stefan@webrtc.org

Review-Url: https://codereview.webrtc.org/3006343002
Cr-Commit-Position: refs/heads/master@{#19777}
Committed: https://chromium.googlesource.com/external/webrtc/+/98b1b7d59e5b9eab61211d3b13dab87cb3bb18ce

[eladalon, 2017-09-11 13:22:19]

eladalon@webrtc.org changed reviewers:
+ danilchap@webrtc.org, stefan@webrtc.org, terelius@webrtc.org

[eladalon, 2017-09-11 13:22:20]

PTAL

[danilchap, 2017-09-11 13:34:21]

RTPHeader already copied sometimes using memcpy

explicit copy constructor is better.

https://codereview.webrtc.org/3006343002/diff/1/webrtc/common_types.h
File webrtc/common_types.h (right):

https://codereview.webrtc.org/3006343002/diff/1/webrtc/common_types.h#newcode795
webrtc/common_types.h:795: RTPHeaderExtension(const RTPHeaderExtension& other);
https://google.github.io/styleguide/cppguide.html#Copyable_Movable_Types

"If you define a copy constructor, define the corresponding assignment operator"

[eladalon, 2017-09-11 14:15:04]

https://codereview.webrtc.org/3006343002/diff/1/webrtc/common_types.h
File webrtc/common_types.h (right):

https://codereview.webrtc.org/3006343002/diff/1/webrtc/common_types.h#newcode795
webrtc/common_types.h:795: RTPHeaderExtension(const RTPHeaderExtension& other);
On 2017/09/11 13:34:21, danilchap wrote:
> https://google.github.io/styleguide/cppguide.html#Copyable_Movable_Types
> 
> "If you define a copy constructor, define the corresponding assignment
operator"

Done.

[danilchap, 2017-09-11 14:20:19]

lgtm

[eladalon, 2017-09-11 15:17:18]

Description was changed from

==========
Add explicit copy constructors to RTPHeader and RTPHeaderExtension

Explicit copy-constructors are required by chromium. (No copy constructors were
used until now, but a different CL requires them.)

BUG=None
==========

to

==========
Add explicit copy constructors to RTPHeader and RTPHeaderExtension

Explicit copy-constructors are required by chromium. (No copy constructors were
used until now, but a different CL requires them.)

BUG=None
TBR=stefan@webrtc.org
==========

[eladalon, 2017-09-11 15:17:23]

The CQ bit was checked by eladalon@webrtc.org

[commit-bot: I haz the power, 2017-09-11 15:17:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-11 15:48:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1505143043407320,
"parent_rev": "4bb3b9c6cbc0aafcd7e9c0b385bb33ceda70ee1a", "commit_rev":
"98b1b7d59e5b9eab61211d3b13dab87cb3bb18ce"}

[commit-bot: I haz the power, 2017-09-11 15:48:32]

Description was changed from

==========
Add explicit copy constructors to RTPHeader and RTPHeaderExtension

Explicit copy-constructors are required by chromium. (No copy constructors were
used until now, but a different CL requires them.)

BUG=None
TBR=stefan@webrtc.org
==========

to

==========
Add explicit copy constructors to RTPHeader and RTPHeaderExtension

Explicit copy-constructors are required by chromium. (No copy constructors were
used until now, but a different CL requires them.)

BUG=None
TBR=stefan@webrtc.org

Review-Url: https://codereview.webrtc.org/3006343002
Cr-Commit-Position: refs/heads/master@{#19777}
Committed:
https://chromium.googlesource.com/external/webrtc/+/98b1b7d59e5b9eab61211d3b1...
==========

[commit-bot: I haz the power, 2017-09-11 15:48:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/98b1b7d59e5b9eab61211d3b1...