Add explicit copy constructors to RTPHeader and RTPHeaderExtension

webrtc/common_types.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 774 matching lines @@
 };
 
 // StreamId represents RtpStreamId which is a string.
 typedef StringRtpHeaderExtension StreamId;
 
 // Mid represents RtpMid which is a string.
 typedef StringRtpHeaderExtension Mid;
 
 struct RTPHeaderExtension {
   RTPHeaderExtension();
+  RTPHeaderExtension(const RTPHeaderExtension& other);

[danilchap, 2017/09/11 13:34:21]

https://google.github.io/styleguide/cppguide.html#Copyable_Movable_Types

"If you define a copy constructor, define the corresponding assignment operator"

[eladalon, 2017/09/11 14:15:03]

Done.

 
   bool hasTransmissionTimeOffset;
   int32_t transmissionTimeOffset;
   bool hasAbsoluteSendTime;
   uint32_t absoluteSendTime;
   bool hasTransportSequenceNumber;
   uint16_t transportSequenceNumber;
 
   // Audio Level includes both level in dBov and voiced/unvoiced bit. See:
   // https://datatracker.ietf.org/doc/draft-lennox-avt-rtp-audio-level-exthdr/
@@ skipping 23 matching lines @@
   StreamId stream_id;
   StreamId repaired_stream_id;
 
   // For identifying the media section used to interpret this RTP packet. See
   // https://tools.ietf.org/html/draft-ietf-mmusic-sdp-bundle-negotiation-38
   Mid mid;
 };
 
 struct RTPHeader {
   RTPHeader();
+  RTPHeader(const RTPHeader& other);
 
   bool markerBit;
   uint8_t payloadType;
   uint16_t sequenceNumber;
   uint32_t timestamp;
   uint32_t ssrc;
   uint8_t numCSRCs;
   uint32_t arrOfCSRCs[kRtpCsrcSize];
   size_t paddingLength;
   size_t headerLength;
@@ skipping 118 matching lines @@
   bool operator==(const RtpKeepAliveConfig& o) const {
     return timeout_interval_ms == o.timeout_interval_ms &&
            payload_type == o.payload_type;
   }
   bool operator!=(const RtpKeepAliveConfig& o) const { return !(*this == o); }
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_COMMON_TYPES_H_