Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 3006243002: Removing WEBRTC_BUILD_LIBEVENT macro definition (Closed)

Created:
3 years, 3 months ago by mbonadei
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing WEBRTC_BUILD_LIBEVENT macro definition This seems to be unused in WebRTC and a search in cs.chromium.orm shows that it is never used in chromium too. Interesting CL about this macro: https://codereview.webrtc.org/2153563003 BUG=None Review-Url: https://codereview.webrtc.org/3006243002 Cr-Commit-Position: refs/heads/master@{#19747} Committed: https://chromium.googlesource.com/external/webrtc/+/63f968e0cef08a88b711e121d61baa86f64fa0b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M webrtc/rtc_base/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mbonadei
I am going to run some Chromium trybots later (I have to fix a problem ...
3 years, 3 months ago (2017-09-08 09:16:46 UTC) #3
kjellander_webrtc
lgtm
3 years, 3 months ago (2017-09-08 09:20:57 UTC) #4
tommi
lgtm. Iirc I used it durning the development of TaskQueue when libevent could optionally be ...
3 years, 3 months ago (2017-09-08 09:26:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3006243002/1
3 years, 3 months ago (2017-09-08 12:49:10 UTC) #7
commit-bot: I haz the power
3 years, 3 months ago (2017-09-08 13:20:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/63f968e0cef08a88b711e121d...

Powered by Google App Engine
This is Rietveld 408576698