Move WEBRTC_BUILD_LIBEVENT definition to base/BUILD.gn and base/base.gyp. This use all_dependent_co…

Move WEBRTC_BUILD_LIBEVENT definition to base/BUILD.gn and base/base.gyp. This use all_dependent_configs (GN) / all_dependent_settings (GYP) to export WEBRTC_BUILD_LIBEVENT to all dependent targets transitively. This fixes a problem with dependent projects in Chromium that indirectly include task_queue.h

BUG=webrtc:5687
R=tommi@webrtc.org

Committed: https://crrev.com/33b9c8fb031dba53272627794338fc2725fb0090
Cr-Commit-Position: refs/heads/master@{#13481}

[perkj_webrtc, 2016-07-14 21:41:06]

perkj@webrtc.org changed reviewers:
+ tommi@webrtc.org

[perkj_webrtc, 2016-07-14 21:41:07]

changed my mind. here is the cl.

[tommi, 2016-07-14 21:47:45]

https://codereview.webrtc.org/2153563003/diff/1/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2153563003/diff/1/webrtc/base/BUILD.gn#newcode221
webrtc/base/BUILD.gn:221: all_dependent_configs = [
Does this also mean that enable_libevent_config is a dependency of
rtc_task_queue?  (i.e. that the define is set for the current target too, not
just dependent ones)

https://codereview.webrtc.org/2153563003/diff/1/webrtc/base/base.gyp
File webrtc/base/base.gyp (right):

https://codereview.webrtc.org/2153563003/diff/1/webrtc/base/base.gyp#newcode160
webrtc/base/base.gyp:160: 'defines': [ 'WEBRTC_BUILD_LIBEVENT' ]
indent seems off

[tommi, 2016-07-14 21:48:33]

lgtm as long as everything builds fine.

[perkj_webrtc, 2016-07-15 06:25:59]

Description was changed from

==========
Move WEBRTC_BUILD_LIBEVENT definition to base/BUILD.gn and base/base.gyp. This
use all_dependent_configs (GN) / all_dependent_settings (GYP) to export
WEBRTC_BUILD_LIBEVENT to all dependent targets transitively. This fixes a
problem with dependent projects in Chromium that indirectly include task_queue.h

BUG=webrtc:5687
==========

to

==========
Move WEBRTC_BUILD_LIBEVENT definition to base/BUILD.gn and base/base.gyp. This
use all_dependent_configs (GN) / all_dependent_settings (GYP) to export
WEBRTC_BUILD_LIBEVENT to all dependent targets transitively. This fixes a
problem with dependent projects in Chromium that indirectly include task_queue.h

BUG=webrtc:5687
R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/33b9c8fb031dba53272627794...
==========

[perkj_webrtc, 2016-07-15 06:26:00]

Committed patchset #2 (id:20001) manually as
33b9c8fb031dba53272627794338fc2725fb0090 (presubmit successful).

[commit-bot: I haz the power, 2016-07-15 06:26:01]

Description was changed from

==========
Move WEBRTC_BUILD_LIBEVENT definition to base/BUILD.gn and base/base.gyp. This
use all_dependent_configs (GN) / all_dependent_settings (GYP) to export
WEBRTC_BUILD_LIBEVENT to all dependent targets transitively. This fixes a
problem with dependent projects in Chromium that indirectly include task_queue.h

BUG=webrtc:5687
R=tommi@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/33b9c8fb031dba53272627794...
==========

to

==========
Move WEBRTC_BUILD_LIBEVENT definition to base/BUILD.gn and base/base.gyp. This
use all_dependent_configs (GN) / all_dependent_settings (GYP) to export
WEBRTC_BUILD_LIBEVENT to all dependent targets transitively. This fixes a
problem with dependent projects in Chromium that indirectly include task_queue.h

BUG=webrtc:5687
R=tommi@webrtc.org

Committed: https://crrev.com/33b9c8fb031dba53272627794338fc2725fb0090
Cr-Commit-Position: refs/heads/master@{#13481}
==========

[perkj_webrtc, 2016-07-15 06:26:19]

https://codereview.webrtc.org/2153563003/diff/1/webrtc/base/BUILD.gn
File webrtc/base/BUILD.gn (right):

https://codereview.webrtc.org/2153563003/diff/1/webrtc/base/BUILD.gn#newcode221
webrtc/base/BUILD.gn:221: all_dependent_configs = [
On 2016/07/14 21:47:44, tommi-webrtc wrote:
> Does this also mean that enable_libevent_config is a dependency of
> rtc_task_queue?  (i.e. that the define is set for the current target too, not
> just dependent ones)

yes, for gn but not gyp.