Replace remaining gflags usages with rtc_base/flags

Replace remaining gflags usages with rtc_base/flags

Continued from https://codereview.webrtc.org/2995363002

BUG=webrtc:7644
Review-Url: https://codereview.webrtc.org/3005483002
Cr-Commit-Position: refs/heads/master@{#19624}
Committed: https://chromium.googlesource.com/external/webrtc/+/6e09d875fb28e49029fac798382e2c8df4a1f752

[oprypin_webrtc, 2017-08-23 18:24:03]

Description was changed from

==========
Replace remaining gflags usages with rtc_base/flags

BUG=webrtc:7644
==========

to

==========
Replace remaining gflags usages with rtc_base/flags

Continued from https://codereview.webrtc.org/2995363002

BUG=webrtc:7644
==========

[oprypin_webrtc, 2017-08-29 13:38:44]

The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-29 13:38:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-29 13:51:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-29 13:51:45]

Dry run: Try jobs failed on following builders:
  win_rel on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_rel/builds/29154)

[oprypin_webrtc, 2017-08-29 14:43:16]

The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-29 14:43:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-29 14:59:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-29 14:59:12]

Dry run: Try jobs failed on following builders:
  ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...)

[oprypin_webrtc, 2017-08-29 18:27:29]

Patchset #6 (id:100001) has been deleted

[oprypin_webrtc, 2017-08-29 18:27:38]

Patchset #6 (id:120001) has been deleted

[oprypin_webrtc, 2017-08-29 18:42:48]

Patchset #6 (id:140001) has been deleted

[oprypin_webrtc, 2017-08-29 18:52:07]

Patchset #6 (id:160001) has been deleted

[oprypin_webrtc, 2017-08-29 18:54:53]

The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-29 18:54:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-29 18:57:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-29 18:57:48]

Dry run: Try jobs failed on following builders:
  mac_baremetal on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/24480)

[oprypin_webrtc, 2017-08-29 19:51:43]

The CQ bit was checked by oprypin@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-08-29 19:51:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-29 20:27:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-08-29 20:27:33]

Dry run: This issue passed the CQ dry run.

[oprypin_webrtc, 2017-08-29 20:27:58]

oprypin@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, kwiberg@webrtc.org

[hlundin-webrtc, 2017-08-30 21:07:54]

LGTM with comments for modules/audio_coding and modules/audio_processing.

https://codereview.webrtc.org/3005483002/diff/190001/webrtc/modules/audio_cod...
File webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc (right):

https://codereview.webrtc.org/3005483002/diff/190001/webrtc/modules/audio_cod...
webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc:123:
DEFINE_int(abs_send_time, 3, "Extension ID for absolute sender time");
I think you will find one more extension if you rebase.

https://codereview.webrtc.org/3005483002/diff/190001/webrtc/modules/audio_pro...
File webrtc/modules/audio_processing/test/conversational_speech/generator.cc
(right):

https://codereview.webrtc.org/3005483002/diff/190001/webrtc/modules/audio_pro...
webrtc/modules/audio_processing/test/conversational_speech/generator.cc:52:
RTC_CHECK(DirExists(FLAG_i));
In these three lines, I think it would be helpful to << a better error message,
since I guess the default printout will be something like "check failed,
expected true, actual false". The user would probably need a reminder of what
flag value was tested.

[oprypin_webrtc, 2017-08-31 00:23:25]

https://codereview.webrtc.org/3005483002/diff/190001/webrtc/modules/audio_cod...
File webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc (right):

https://codereview.webrtc.org/3005483002/diff/190001/webrtc/modules/audio_cod...
webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc:123:
DEFINE_int(abs_send_time, 3, "Extension ID for absolute sender time");
On 2017/08/30 21:07:54, hlundin-webrtc wrote:
> I think you will find one more extension if you rebase.

Rebased.

https://codereview.webrtc.org/3005483002/diff/190001/webrtc/modules/audio_pro...
File webrtc/modules/audio_processing/test/conversational_speech/generator.cc
(right):

https://codereview.webrtc.org/3005483002/diff/190001/webrtc/modules/audio_pro...
webrtc/modules/audio_processing/test/conversational_speech/generator.cc:52:
RTC_CHECK(DirExists(FLAG_i));
On 2017/08/30 21:07:54, hlundin-webrtc wrote:
> In these three lines, I think it would be helpful to << a better error
message,
> since I guess the default printout will be something like "check failed,
> expected true, actual false". The user would probably need a reminder of what
> flag value was tested.

I did make sure that there's always at least some hint to what's going wrong
with the flags. That's ensured by RTC_CHECK echoing its contents.
It actually looks like this:
  # Fatal error in
../../webrtc/modules/audio_processing/test/conversational_speech/generator.cc,
line 52
  # last system error: 2
  # Check failed: DirExists(FLAG_i)
vs previous:
  ERROR: failed validation of new value '...' for flag 'i'

So I think it's good.

[hlundin-webrtc, 2017-08-31 05:59:20]

LGTM for modules/audio_coding and modules/audio_processing.

https://codereview.webrtc.org/3005483002/diff/190001/webrtc/modules/audio_pro...
File webrtc/modules/audio_processing/test/conversational_speech/generator.cc
(right):

https://codereview.webrtc.org/3005483002/diff/190001/webrtc/modules/audio_pro...
webrtc/modules/audio_processing/test/conversational_speech/generator.cc:52:
RTC_CHECK(DirExists(FLAG_i));
On 2017/08/31 00:23:25, oprypin_webrtc wrote:
> On 2017/08/30 21:07:54, hlundin-webrtc wrote:
> > In these three lines, I think it would be helpful to << a better error
> message,
> > since I guess the default printout will be something like "check failed,
> > expected true, actual false". The user would probably need a reminder of
what
> > flag value was tested.
> 
> I did make sure that there's always at least some hint to what's going wrong
> with the flags. That's ensured by RTC_CHECK echoing its contents.
> It actually looks like this:
>   # Fatal error in
> ../../webrtc/modules/audio_processing/test/conversational_speech/generator.cc,
> line 52
>   # last system error: 2
>   # Check failed: DirExists(FLAG_i)
> vs previous:
>   ERROR: failed validation of new value '...' for flag 'i'
> 
> So I think it's good.

OK. Fair enough.

[kwiberg-webrtc, 2017-08-31 09:23:38]

lgtm

[oprypin_webrtc, 2017-08-31 09:44:15]

The CQ bit was checked by oprypin@webrtc.org

[commit-bot: I haz the power, 2017-08-31 09:44:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-31 10:21:40]

CQ is committing da patch.

Bot data: {"patchset_id": 230001, "attempt_start_ts": 1504172655078030,
"parent_rev": "f2972ba1665557fdec5691622c92c0aef869e0f1", "commit_rev":
"6e09d875fb28e49029fac798382e2c8df4a1f752"}

[commit-bot: I haz the power, 2017-08-31 10:21:46]

Description was changed from

==========
Replace remaining gflags usages with rtc_base/flags

Continued from https://codereview.webrtc.org/2995363002

BUG=webrtc:7644
==========

to

==========
Replace remaining gflags usages with rtc_base/flags

Continued from https://codereview.webrtc.org/2995363002

BUG=webrtc:7644

Review-Url: https://codereview.webrtc.org/3005483002
Cr-Commit-Position: refs/heads/master@{#19624}
Committed:
https://chromium.googlesource.com/external/webrtc/+/6e09d875fb28e49029fac7983...
==========

[commit-bot: I haz the power, 2017-08-31 10:21:47]

Committed patchset #9 (id:230001) as
https://chromium.googlesource.com/external/webrtc/+/6e09d875fb28e49029fac7983...