webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_gencfgs.py - Issue 3005483002: Replace remaining gflags usages with rtc_base/flags

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_gencfgs.py

Issue 3005483002: Replace remaining gflags usages with rtc_base/flags (Closed)

Patch Set: Rebase Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/test/conversational_speech/generator.cc ('k') | webrtc/modules/audio_processing/test/unpack.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_gencfgs.py

diff --git a/webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_gencfgs.py b/webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_gencfgs.py

index d2764b06d1df174dfce18fb8d674d1a6a383cd4d..338c38c1060d4c85a32ce110aafcc430221d3727 100755

--- a/webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_gencfgs.py

+++ b/webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment_gencfgs.py

@@ -27,7 +27,7 @@ def _GenerateDefaultOverridden(config_override):

The default settings are loaded via "-all_default".

Check "src/webrtc/modules/audio_processing/test/audioproc_float.cc" and search

- for "if (FLAGS_all_default) {".

+ for "if (FLAG_all_default) {".

For instance, in 55eb6d621489730084927868fed195d3645a9ec9 the default is this:

settings.use_aec = rtc::Optional<bool>(true);