Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 3004983002: Remove VideoProcessorIntegrationTest::SetTestConfig. (Closed)

Created:
3 years, 3 months ago by brandtr
Modified:
3 years, 3 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VideoProcessorIntegrationTest::SetTestConfig. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/3004983002 Cr-Commit-Position: refs/heads/master@{#19648} Committed: https://chromium.googlesource.com/external/webrtc/+/ffbe1cd07ef1b20a59415a0d440e8684505a2902

Patch Set 1 #

Total comments: 6

Patch Set 2 : asapersson comments 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -86 lines) Patch
M webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc View 1 4 chunks +10 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 chunk +0 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_libvpx.cc View 1 13 chunks +35 lines, -45 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest_openh264.cc View 1 2 chunks +19 lines, -12 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 26 (15 generated)
brandtr
PTAL. bot failure is due to swarming failure.
3 years, 3 months ago (2017-09-01 08:45:55 UTC) #3
åsapersson
lgtm https://codereview.webrtc.org/3004983002/diff/20001/webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc File webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc (right): https://codereview.webrtc.org/3004983002/diff/20001/webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc#newcode59 webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc:59: const std::string& filename) { set config_.filename = filename? ...
3 years, 3 months ago (2017-09-01 11:49:31 UTC) #4
brandtr
https://codereview.webrtc.org/3004983002/diff/20001/webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc File webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc (right): https://codereview.webrtc.org/3004983002/diff/20001/webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc#newcode59 webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc:59: const std::string& filename) { On 2017/09/01 11:49:31, åsapersson wrote: ...
3 years, 3 months ago (2017-09-01 13:26:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3004983002/60001
3 years, 3 months ago (2017-09-01 13:27:06 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_tsan2 on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_tsan2/builds/25644)
3 years, 3 months ago (2017-09-01 14:38:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3004983002/60001
3 years, 3 months ago (2017-09-04 06:37:04 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/27370)
3 years, 3 months ago (2017-09-04 06:47:34 UTC) #19
oprypin_webrtc
On 2017/09/04 06:47:34, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 3 months ago (2017-09-04 08:10:22 UTC) #20
brandtr
On 2017/09/04 08:10:22, oprypin_webrtc wrote: > On 2017/09/04 06:47:34, commit-bot: I haz the power wrote: ...
3 years, 3 months ago (2017-09-04 08:40:45 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3004983002/60001
3 years, 3 months ago (2017-09-04 08:40:47 UTC) #23
commit-bot: I haz the power
3 years, 3 months ago (2017-09-04 10:03:48 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/ffbe1cd07ef1b20a59415a0d4...

Powered by Google App Engine
This is Rietveld 408576698