Add ability to instantiate VideoEncoderSoftwareFallback in VP tests.

Add ability to instantiate VideoEncoderSoftwareFallback in VP tests.

* Split TestConfig::hw_codec into hw_encoder and hw_decoder.
* Add TestConfig::sw_fallback_encoder.

BUG=webrtc:6634
Review-Url: https://codereview.webrtc.org/3009963002
Cr-Commit-Position: refs/heads/master@{#19710}
Committed: https://chromium.googlesource.com/external/webrtc/+/d635e5b8ed2e77d4dac6b08d0f33f6fba466632e

[brandtr, 2017-09-01 08:16:56]

Description was changed from

==========
Add ability to instantiate VideoEncoderSoftwareFallback in VP tests.

BUG=webrtc:6634
==========

to

==========
Add ability to instantiate VideoEncoderSoftwareFallback in VP tests.

* Split TestConfig::hw_codec into hw_encoder and hw_decoder.
* Add TestConfig::sw_fallback_encoder.

BUG=webrtc:6634
==========

[brandtr, 2017-09-01 08:47:37]

brandtr@webrtc.org changed reviewers:
+ asapersson@webrtc.org

[brandtr, 2017-09-01 08:47:38]

This one too :)

[brandtr, 2017-09-01 12:30:18]

Rebase.

[brandtr, 2017-09-04 11:27:53]

Rebase.

[brandtr, 2017-09-04 12:37:05]

Rebase.

[brandtr, 2017-09-05 10:38:23]

brandtr@webrtc.org changed reviewers:
+ srte@webrtc.org

[brandtr, 2017-09-05 10:38:24]

srte, can you take a look since Åsa is ooo?

[srte, 2017-09-05 11:11:08]

lgtm

https://codereview.webrtc.org/3009963002/diff/60001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc
(right):

https://codereview.webrtc.org/3009963002/diff/60001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc:311:
cricket::VideoCodec codec;
Since this seems to only be used for the encoder config: Might be reasonable to
name it encoder_codec for clarity.

https://codereview.webrtc.org/3009963002/diff/60001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc:399:
encoder_.get(), decoder_, analysis_frame_reader_.get(),
Somewhat dangerous call to .get() here, just make sure lifetime of encoder_
(including any resets etc) is guaranteed to surpass the lifetime or processor_.
Might be good to state this assumption in a comment here as well. Or preferably:
Make VideoProcessor take a smart pointer.

[brandtr, 2017-09-06 08:55:32]

Rebase.

[brandtr, 2017-09-06 11:17:27]

https://codereview.webrtc.org/3009963002/diff/60001/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc
(right):

https://codereview.webrtc.org/3009963002/diff/60001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc:311:
cricket::VideoCodec codec;
On 2017/09/05 11:11:07, srte wrote:
> Since this seems to only be used for the encoder config: Might be reasonable
to
> name it encoder_codec for clarity.

Done.

https://codereview.webrtc.org/3009963002/diff/60001/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc:399:
encoder_.get(), decoder_, analysis_frame_reader_.get(),
On 2017/09/05 11:11:07, srte wrote:
> Somewhat dangerous call to .get() here, just make sure lifetime of encoder_
> (including any resets etc) is guaranteed to surpass the lifetime or
processor_.
> Might be good to state this assumption in a comment here as well. Or
preferably:
> Make VideoProcessor take a smart pointer.

Yes, the lifetime of the objects passed in here need to be carefully managed by
the VideoProcessorIntegrationTest. I'll add a comment for now, and when we can
put the VideoDecoder in a std::unique_ptr, I can std::move both codecs into the
VideoProcessor.

[brandtr, 2017-09-06 11:17:59]

The CQ bit was checked by brandtr@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-09-06 11:18:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-06 11:41:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-09-06 11:41:21]

Dry run: This issue passed the CQ dry run.

[brandtr, 2017-09-06 11:45:54]

The CQ bit was checked by brandtr@webrtc.org

[brandtr, 2017-09-06 11:45:55]

The patchset sent to the CQ was uploaded after l-g-t-m from srte@webrtc.org
Link to the patchset: https://codereview.webrtc.org/3009963002/#ps100001 (title:
"srte comments 1.")

[commit-bot: I haz the power, 2017-09-06 11:46:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-09-06 11:48:22]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1504698354516350,
"parent_rev": "341c8e40b7f7202b13a4b93e225f4ec8320c9eea", "commit_rev":
"d635e5b8ed2e77d4dac6b08d0f33f6fba466632e"}

[commit-bot: I haz the power, 2017-09-06 11:48:31]

Description was changed from

==========
Add ability to instantiate VideoEncoderSoftwareFallback in VP tests.

* Split TestConfig::hw_codec into hw_encoder and hw_decoder.
* Add TestConfig::sw_fallback_encoder.

BUG=webrtc:6634
==========

to

==========
Add ability to instantiate VideoEncoderSoftwareFallback in VP tests.

* Split TestConfig::hw_codec into hw_encoder and hw_decoder.
* Add TestConfig::sw_fallback_encoder.

BUG=webrtc:6634

Review-Url: https://codereview.webrtc.org/3009963002
Cr-Commit-Position: refs/heads/master@{#19710}
Committed:
https://chromium.googlesource.com/external/webrtc/+/d635e5b8ed2e77d4dac6b08d0...
==========

[commit-bot: I haz the power, 2017-09-06 11:48:32]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/d635e5b8ed2e77d4dac6b08d0...