Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Issue 3004013002: Fix memory leak in VideoToolbox encoder. (Closed)

Created:
3 years, 3 months ago by kthelgason
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix memory leak in VideoToolbox encoder. We were leaking a fragmentation header object on each frame. BUG=webrtc:8132 Review-Url: https://codereview.webrtc.org/3004013002 Cr-Commit-Position: refs/heads/master@{#19602} Committed: https://chromium.googlesource.com/external/webrtc/+/f8084d485b87e49a68ff8e46e07bc01d375586be

Patch Set 1 #

Total comments: 5

Patch Set 2 : Code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M webrtc/sdk/objc/Framework/Classes/VideoToolbox/RTCVideoEncoderH264.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc View 1 3 chunks +4 lines, -5 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (5 generated)
kthelgason
This fix just affects H264, and there may be other leaks, but at least this ...
3 years, 3 months ago (2017-08-29 09:44:11 UTC) #2
kthelgason
3 years, 3 months ago (2017-08-29 09:47:42 UTC) #4
henrika_webrtc
Nice. lgtm
3 years, 3 months ago (2017-08-29 10:37:07 UTC) #5
henrika_webrtc
https://codereview.webrtc.org/3004013002/diff/1/webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc File webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc (right): https://codereview.webrtc.org/3004013002/diff/1/webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc#newcode155 webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc:155: out_header->reset(header); Should it be documented that we deleted and ...
3 years, 3 months ago (2017-08-29 10:37:12 UTC) #6
magjed_webrtc
https://codereview.webrtc.org/3004013002/diff/1/webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc File webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc (right): https://codereview.webrtc.org/3004013002/diff/1/webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc#newcode146 webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc:146: auto header = new webrtc::RTPFragmentationHeader(); Can't we put it ...
3 years, 3 months ago (2017-08-29 11:35:02 UTC) #7
kthelgason
https://codereview.webrtc.org/3004013002/diff/1/webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc File webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc (right): https://codereview.webrtc.org/3004013002/diff/1/webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc#newcode146 webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc:146: auto header = new webrtc::RTPFragmentationHeader(); On 2017/08/29 11:35:02, magjed_webrtc ...
3 years, 3 months ago (2017-08-29 11:39:46 UTC) #8
magjed_webrtc
https://codereview.webrtc.org/3004013002/diff/1/webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc File webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc (right): https://codereview.webrtc.org/3004013002/diff/1/webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc#newcode146 webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc:146: auto header = new webrtc::RTPFragmentationHeader(); On 2017/08/29 11:39:45, kthelgason ...
3 years, 3 months ago (2017-08-30 09:06:10 UTC) #9
kthelgason
https://codereview.webrtc.org/3004013002/diff/1/webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc File webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc (right): https://codereview.webrtc.org/3004013002/diff/1/webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc#newcode146 webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc:146: auto header = new webrtc::RTPFragmentationHeader(); On 2017/08/30 09:06:10, magjed_webrtc ...
3 years, 3 months ago (2017-08-30 09:13:41 UTC) #10
henrika_webrtc
lgtm++
3 years, 3 months ago (2017-08-30 09:19:49 UTC) #11
magjed_webrtc
lgtm
3 years, 3 months ago (2017-08-30 10:58:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3004013002/20001
3 years, 3 months ago (2017-08-30 10:58:49 UTC) #14
commit-bot: I haz the power
3 years, 3 months ago (2017-08-30 11:47:21 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/f8084d485b87e49a68ff8e46e...

Powered by Google App Engine
This is Rietveld 408576698