webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm - Issue 3004013002: Fix memory leak in VideoToolbox encoder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm

Issue 3004013002: Fix memory leak in VideoToolbox encoder. (Closed)

Patch Set: Code review Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm

diff --git a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm

index c3de9ae7061eb32009ba612c30c556d8b5d135c7..75b4a34a3abc1817e3a1cbea0c7ab5fc9be7fa5e 100644

--- a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm

+++ b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm

@@ -78,7 +78,7 @@ class ObjCVideoEncoder : public VideoEncoder {

std::unique_ptr<RTPFragmentationHeader> fragmentationHeader =

[header createNativeFragmentationHeader];

EncodedImageCallback::Result res =

- callback->OnEncodedImage(encodedImage, &codecSpecificInfo, fragmentationHeader.release());

+ callback->OnEncodedImage(encodedImage, &codecSpecificInfo, fragmentationHeader.get());

return res.error == EncodedImageCallback::Result::OK;

}];

« no previous file with comments | « webrtc/sdk/objc/Framework/Classes/VideoToolbox/nalu_rewriter.cc ('k') | no next file » | no next file with comments »