Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 3003843002: Android: Expose EglBase.swapBuffers with presentation time (Closed)

Created:
3 years, 3 months ago by magjed_webrtc
Modified:
3 years, 3 months ago
Reviewers:
sakal
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android: Expose EglBase.swapBuffers with presentation time This function is currently only available in EglBase14, which is not in the api. This CL adds the swapBuffer method to the public EglBase interface. For EglBase10, the presentation time is just ignored. BUG=webrtc:8155 Review-Url: https://codereview.webrtc.org/3003843002 Cr-Commit-Position: refs/heads/master@{#19518} Committed: https://chromium.googlesource.com/external/webrtc/+/4781552f6098d07c4af909ab0740e6b4358fd32b

Patch Set 1 #

Patch Set 2 : Make EglBase an interface #

Patch Set 3 : Suppress warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -18 lines) Patch
M webrtc/sdk/android/api/org/webrtc/EglBase.java View 1 2 3 chunks +19 lines, -16 lines 0 comments Download
M webrtc/sdk/android/src/java/org/webrtc/EglBase10.java View 1 2 chunks +7 lines, -1 line 0 comments Download
M webrtc/sdk/android/src/java/org/webrtc/EglBase14.java View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (14 generated)
magjed_webrtc
Sami - please take a look.
3 years, 3 months ago (2017-08-25 13:09:20 UTC) #12
sakal
lgtm
3 years, 3 months ago (2017-08-25 13:15:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3003843002/40001
3 years, 3 months ago (2017-08-25 13:26:01 UTC) #15
commit-bot: I haz the power
3 years, 3 months ago (2017-08-25 13:28:08 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/4781552f6098d07c4af909ab0...

Powered by Google App Engine
This is Rietveld 408576698