Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: webrtc/sdk/android/api/org/webrtc/EglBase.java

Issue 3003843002: Android: Expose EglBase.swapBuffers with presentation time (Closed)
Patch Set: Suppress warning Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/sdk/android/src/java/org/webrtc/EglBase10.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/android/api/org/webrtc/EglBase.java
diff --git a/webrtc/sdk/android/api/org/webrtc/EglBase.java b/webrtc/sdk/android/api/org/webrtc/EglBase.java
index 619022c770eb32bfb29c5861e8b782c65cadb4c5..2a8d4e4bd19bf47be708a3eeac9584bf2cd2846b 100644
--- a/webrtc/sdk/android/api/org/webrtc/EglBase.java
+++ b/webrtc/sdk/android/api/org/webrtc/EglBase.java
@@ -19,7 +19,8 @@ import javax.microedition.khronos.egl.EGL10;
* Holds EGL state and utility methods for handling an egl 1.0 EGLContext, an EGLDisplay,
* and an EGLSurface.
*/
-public abstract class EglBase {
+@SuppressWarnings("StaticOrDefaultInterfaceMethod")
+public interface EglBase {
// EGL wrapper for an actual EGLContext.
public static class Context {}
@@ -33,9 +34,9 @@ public abstract class EglBase {
// https://android.googlesource.com/platform/frameworks/base/+/master/opengl/java/android/opengl/EGL14.java
// This is similar to how GlSurfaceView does:
// http://grepcode.com/file/repository.grepcode.com/java/ext/com.google.android/android/5.1.1_r1/android/opengl/GLSurfaceView.java#760
- private static final int EGL_OPENGL_ES2_BIT = 4;
+ public static final int EGL_OPENGL_ES2_BIT = 4;
// Android-specific extension.
- private static final int EGL_RECORDABLE_ANDROID = 0x3142;
+ public static final int EGL_RECORDABLE_ANDROID = 0x3142;
// clang-format off
public static final int[] CONFIG_PLAIN = {
@@ -140,32 +141,34 @@ public abstract class EglBase {
return new EglBase14(new EglBase14.Context(sharedContext), configAttributes);
}
- public abstract void createSurface(Surface surface);
+ void createSurface(Surface surface);
// Create EGLSurface from the Android SurfaceTexture.
- public abstract void createSurface(SurfaceTexture surfaceTexture);
+ void createSurface(SurfaceTexture surfaceTexture);
// Create dummy 1x1 pixel buffer surface so the context can be made current.
- public abstract void createDummyPbufferSurface();
+ void createDummyPbufferSurface();
- public abstract void createPbufferSurface(int width, int height);
+ void createPbufferSurface(int width, int height);
- public abstract Context getEglBaseContext();
+ Context getEglBaseContext();
- public abstract boolean hasSurface();
+ boolean hasSurface();
- public abstract int surfaceWidth();
+ int surfaceWidth();
- public abstract int surfaceHeight();
+ int surfaceHeight();
- public abstract void releaseSurface();
+ void releaseSurface();
- public abstract void release();
+ void release();
- public abstract void makeCurrent();
+ void makeCurrent();
// Detach the current EGL context, so that it can be made current on another thread.
- public abstract void detachCurrent();
+ void detachCurrent();
- public abstract void swapBuffers();
+ void swapBuffers();
+
+ void swapBuffers(long presentationTimeStampNs);
}
« no previous file with comments | « no previous file | webrtc/sdk/android/src/java/org/webrtc/EglBase10.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698