Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 3003723002: Fix places that trigger no-unused-lambda-capture - change to using static-constexpr (Closed)

Created:
3 years, 4 months ago by eladalon
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, mflodman, kwiberg-webrtc, minyue-webrtc, the sun, yujie_mao (webrtc), zhengzhonghou_agora.io, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix places that trigger no-unused-lambda-capture - change to using static-constexpr. Follow up on https://codereview.webrtc.org/3005433002/. BUG=webrtc:7133 TBR=stefan@webrtc.org Review-Url: https://codereview.webrtc.org/3003723002 Cr-Commit-Position: refs/heads/master@{#19499} Committed: https://chromium.googlesource.com/external/webrtc/+/05b07bb833328515f7e86b769a7660008f0f498e

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -25 lines) Patch
M webrtc/modules/audio_processing/aec3/adaptive_fir_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/residual_echo_estimator.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/pc/channel_unittest.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 2 chunks +4 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
eladalon
PTAL
3 years, 4 months ago (2017-08-23 14:04:00 UTC) #3
nisse-webrtc
lgtm. But maybe best to wait for https://codereview.webrtc.org/2999403002/ before landing?
3 years, 4 months ago (2017-08-23 14:18:40 UTC) #4
eladalon
On 2017/08/23 14:18:40, nisse-webrtc wrote: > lgtm. But maybe best to wait for https://codereview.webrtc.org/2999403002/ > ...
3 years, 4 months ago (2017-08-23 14:41:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3003723002/1
3 years, 4 months ago (2017-08-23 14:42:49 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on master.tryserver.webrtc (JOB_TIMED_OUT, build has not started yet; ...
3 years, 4 months ago (2017-08-23 16:43:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3003723002/20001
3 years, 4 months ago (2017-08-24 14:03:44 UTC) #13
commit-bot: I haz the power
3 years, 4 months ago (2017-08-24 14:40:22 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/05b07bb833328515f7e86b769...

Powered by Google App Engine
This is Rietveld 408576698