webrtc/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc - Issue 3003723002: Fix places that trigger no-unused-lambda-capture - change to using static-constexpr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc

Issue 3003723002: Fix places that trigger no-unused-lambda-capture - change to using static-constexpr (Closed)

Patch Set: Rebased Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_processing/aec3/adaptive_fir_filter.cc ('k') | webrtc/modules/audio_processing/aec3/residual_echo_estimator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc

diff --git a/webrtc/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc b/webrtc/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc

index b9ab201991abda7948e15e453f27febfbff0e913..ddc7896de6f5ecbf798a620a965514963260a24c 100644

--- a/webrtc/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc

+++ b/webrtc/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc

@@ -337,10 +337,10 @@ TEST(AdaptiveFirFilter, FilterAndAdapt) {

delay_buffer.Delay(x[0], y);

RandomizeSampleVector(&random_generator, n);

- const float kNoiseScaling = 1.f / 100.f;

+ static constexpr float kNoiseScaling = 1.f / 100.f;

std::transform(

y.begin(), y.end(), n.begin(), y.begin(),

- [kNoiseScaling](float a, float b) { return a + b * kNoiseScaling; });

+ [](float a, float b) { return a + b * kNoiseScaling; });

x_hp_filter.Process(x[0]);

y_hp_filter.Process(y);