Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Issue 3003473002: Only disable -Wthread-safety-attributes warning for Clang. (Closed)

Created:
3 years, 4 months ago by kjellander_webrtc
Modified:
3 years, 4 months ago
Reviewers:
hbos
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Only disable -Wthread-safety-attributes warning for Clang. Clang is enabled by default and we currently lack coverage for building on Windows with MSVC (see crbug.com/757293). This should unblock rolling WebRTC into Chromium DEPS. We need to improve our trybot coverage for standalone WebRTC to prevent things like this in the future though (crbug.com/756840). BUG=webrtc:8119, chromium:756840, chromium:757293 TBR=hbos@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/3003473002 Cr-Commit-Position: refs/heads/master@{#19420} Committed: https://chromium.googlesource.com/external/webrtc/+/8b844b16eb8d71313d6b5a06e9469f968fcb0446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M webrtc/modules/video_coding/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
kjellander_webrtc
3 years, 4 months ago (2017-08-21 04:32:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3003473002/1
3 years, 4 months ago (2017-08-21 04:34:31 UTC) #4
commit-bot: I haz the power
3 years, 4 months ago (2017-08-21 04:37:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/8b844b16eb8d71313d6b5a06e...

Powered by Google App Engine
This is Rietveld 408576698