Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: webrtc/modules/video_coding/BUILD.gn

Issue 3003473002: Only disable -Wthread-safety-attributes warning for Clang. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../../webrtc.gni") 9 import("../../webrtc.gni")
10 10
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 "../../rtc_base:rtc_base_approved", 141 "../../rtc_base:rtc_base_approved",
142 "../../rtc_base:rtc_numerics", 142 "../../rtc_base:rtc_numerics",
143 "../../rtc_base:rtc_task_queue", 143 "../../rtc_base:rtc_task_queue",
144 "../../rtc_base:sequenced_task_checker", 144 "../../rtc_base:sequenced_task_checker",
145 "../../system_wrappers", 145 "../../system_wrappers",
146 ] 146 ]
147 } 147 }
148 148
149 # TODO(ehmaldonado): Remove once http://bugs.webrtc.org/8090 is fixed. 149 # TODO(ehmaldonado): Remove once http://bugs.webrtc.org/8090 is fixed.
150 config("webrtc_h264_config") { 150 config("webrtc_h264_config") {
151 cflags = [ "-Wno-thread-safety-attributes" ] 151 if (is_clang) {
152 cflags = [ "-Wno-thread-safety-attributes" ]
153 }
152 } 154 }
153 155
154 rtc_static_library("webrtc_h264") { 156 rtc_static_library("webrtc_h264") {
155 sources = [ 157 sources = [
156 "codecs/h264/h264.cc", 158 "codecs/h264/h264.cc",
157 "codecs/h264/include/h264.h", 159 "codecs/h264/include/h264.h",
158 ] 160 ]
159 161
160 if (!build_with_chromium && is_clang) { 162 if (!build_with_chromium && is_clang) {
161 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 163 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
641 } 643 }
642 644
643 # TODO(jschuh): bugs.webrtc.org/1348: fix this warning. 645 # TODO(jschuh): bugs.webrtc.org/1348: fix this warning.
644 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] 646 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
645 if (!build_with_chromium && is_clang) { 647 if (!build_with_chromium && is_clang) {
646 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 648 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
647 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 649 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
648 } 650 }
649 } 651 }
650 } 652 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698