Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 3002553002: Add support for adding VideoSinks to VideoTracks. (Closed)

Created:
3 years, 4 months ago by sakal
Modified:
3 years, 4 months ago
Reviewers:
kthelgason
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add support for adding VideoSinks to VideoTracks. VideoSinks receive the new kind of VideoFrames and will replace VideoRenderers. Converting from old texture frames to VideoFrames will involve conversion to I420 so it is not recommended to use VideoSinks before all sources produce VideoFrames. BUG=webrtc:7749, webrtc:7760 Review-Url: https://codereview.webrtc.org/3002553002 Cr-Commit-Position: refs/heads/master@{#19335} Committed: https://chromium.googlesource.com/external/webrtc/+/0ba43b5a2045b0b6de4c8e374895462961330b85

Patch Set 1 #

Patch Set 2 : Add documentation, fix bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -30 lines) Patch
M webrtc/sdk/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A webrtc/sdk/android/api/org/webrtc/VideoSink.java View 1 chunk +23 lines, -0 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/VideoTrack.java View 1 2 chunks +40 lines, -4 lines 0 comments Download
M webrtc/sdk/android/src/java/org/webrtc/WrappedNativeI420Buffer.java View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/classreferenceholder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/native_handle_impl.cc View 2 chunks +28 lines, -10 lines 0 comments Download
M webrtc/sdk/android/src/jni/videotrack_jni.cc View 1 chunk +60 lines, -13 lines 0 comments Download
M webrtc/sdk/android/src/jni/wrapped_native_i420_buffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/wrapped_native_i420_buffer.cc View 1 chunk +1 line, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
sakal
PTAL
3 years, 4 months ago (2017-08-14 11:17:51 UTC) #2
kthelgason
looks legit, lgtm
3 years, 4 months ago (2017-08-14 11:37:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3002553002/20001
3 years, 4 months ago (2017-08-14 11:39:16 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-08-14 12:17:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/0ba43b5a2045b0b6de4c8e374...

Powered by Google App Engine
This is Rietveld 408576698