Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 3002563002: Add VideoSink interface to SurfaceViewRenderer. (Closed)

Created:
3 years, 4 months ago by sakal
Modified:
3 years, 4 months ago
Reviewers:
kthelgason
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add VideoSink interface to SurfaceViewRenderer. BUG=webrtc:7749, webrtc:7760 Review-Url: https://codereview.webrtc.org/3002563002 Cr-Commit-Position: refs/heads/master@{#19347} Committed: https://chromium.googlesource.com/external/webrtc/+/6bdcefce80b42ddc7e8c754988f86c8e214aee83

Patch Set 1 : SUppressWarnings #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -59 lines) Patch
M webrtc/sdk/android/api/org/webrtc/EglRenderer.java View 13 chunks +84 lines, -54 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/RendererCommon.java View 3 chunks +33 lines, -4 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java View 1 2 3 chunks +41 lines, -1 line 0 comments Download
M webrtc/sdk/android/api/org/webrtc/VideoFrame.java View 2 chunks +17 lines, -0 lines 0 comments Download
M webrtc/sdk/android/api/org/webrtc/VideoRenderer.java View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
sakal
PTAL
3 years, 4 months ago (2017-08-14 14:41:57 UTC) #10
kthelgason
lgtm https://codereview.webrtc.org/3002563002/diff/40001/webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java File webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java (right): https://codereview.webrtc.org/3002563002/diff/40001/webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java#newcode374 webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java:374: post(new Runnable() { Can you not use the ...
3 years, 4 months ago (2017-08-15 07:45:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3002563002/80001
3 years, 4 months ago (2017-08-15 08:18:10 UTC) #14
sakal
https://codereview.webrtc.org/3002563002/diff/40001/webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java File webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java (right): https://codereview.webrtc.org/3002563002/diff/40001/webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java#newcode374 webrtc/sdk/android/api/org/webrtc/SurfaceViewRenderer.java:374: post(new Runnable() { On 2017/08/15 07:45:24, kthelgason wrote: > ...
3 years, 4 months ago (2017-08-15 08:18:13 UTC) #15
commit-bot: I haz the power
3 years, 4 months ago (2017-08-15 08:56:20 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/6bdcefce80b42ddc7e8c75498...

Powered by Google App Engine
This is Rietveld 408576698