Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 3002203002: Reland of Enable -Wunused-lambda-capture warning (Closed)

Created:
3 years, 4 months ago by kjellander_webrtc
Modified:
3 years, 4 months ago
Reviewers:
charujain1, charujain
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, eladalon
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Enable -Wunused-lambda-capture warning (patchset #1 id:1 of https://codereview.webrtc.org/3007483002/ ) Reason for revert: Relanding not enabling the warning if Xcode clang is used. See https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?rcl=9de57af4acd3e74cde57e62dd48e58290eeb1481&l=1216 for details. Original issue's description: > Revert of Enable -Wunused-lambda-capture warning (patchset #1 id:1 of https://codereview.webrtc.org/2999403002/ ) > > Reason for revert: > Breaks iOS framework builder. > > Original issue's description: > > Enable -Wunused-lambda-capture warning > > > > This should prevent some build errors downstream. > > The warning is currrently disabled in Chromium: > > https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?rcl=735aa36217a394455f70aad87e2c844053fd810a&l=1214 > > (see https://crbug.com/681136 for more info). > > > > BUG=webrtc:7133 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2999403002 > > Cr-Commit-Position: refs/heads/master@{#19466} > > Committed: https://chromium.googlesource.com/external/webrtc/+/fd7cffa43366d5fb8a95da71fffa7f872037fefe > > TBR=charujain@webrtc.org,charujain@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7133 > > Review-Url: https://codereview.webrtc.org/3007483002 > Cr-Commit-Position: refs/heads/master@{#19473} > Committed: https://chromium.googlesource.com/external/webrtc/+/aa0d2e694a965c72b5adc0c7779b81e850db46e6 TBR=charujain@webrtc.org,charujain@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7133 Review-Url: https://codereview.webrtc.org/3002203002 Cr-Commit-Position: refs/heads/master@{#19475} Committed: https://chromium.googlesource.com/external/webrtc/+/d4ab933e2c6142e0d398b0afd30626b476f7082f

Patch Set 1 #

Patch Set 2 : Excluding Xcode clang usage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M webrtc/BUILD.gn View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kjellander_webrtc
Created Reland of Enable -Wunused-lambda-capture warning
3 years, 4 months ago (2017-08-23 19:02:39 UTC) #1
kjellander_webrtc
Looks good, my mistake to not run that bot in my previous CL :(
3 years, 4 months ago (2017-08-23 19:28:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3002203002/40001
3 years, 4 months ago (2017-08-23 19:31:28 UTC) #5
commit-bot: I haz the power
3 years, 4 months ago (2017-08-23 19:31:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/d4ab933e2c6142e0d398b0afd...

Powered by Google App Engine
This is Rietveld 408576698