Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 4 months ago by kjellander_webrtc Modified:
3 years, 4 months ago Reviewers:
charujain1, charujain CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc, eladalon Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionEnable -Wunused-lambda-capture warning
This should prevent some build errors downstream.
The warning is currrently disabled in Chromium:
https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?rcl=735aa36217a394455f70aad87e2c844053fd810a&l=1214
(see https://crbug.com/681136 for more info).
BUG=webrtc:7133
NOTRY=True
Review-Url: https://codereview.webrtc.org/2999403002
Cr-Commit-Position: refs/heads/master@{#19466}
Committed: https://chromium.googlesource.com/external/webrtc/+/fd7cffa43366d5fb8a95da71fffa7f872037fefe
Patch Set 1 #
Created: 3 years, 4 months ago
Messages
Total messages: 20 (10 generated)
Description was changed from ========== Enable -Wunused-lambda-capture warning This should prevent some build errors downstream. The warning is currrently disabled in Chromium: https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?rcl=735aa... (see https://crbug.com/681136 for more info). BUG=webrtc:7133 NOTRY=True ========== to ========== Enable -Wunused-lambda-capture warning This should prevent some build errors downstream. The warning is currrently disabled in Chromium: https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?rcl=735aa... (see https://crbug.com/681136 for more info). BUG=webrtc:7133 NOTRY=True ==========
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
kjellander@webrtc.org changed reviewers: + charujain@webrtc.org
charujain@google.com changed reviewers: + charujain@google.com
lgtm
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
The CQ bit was checked by charujain@webrtc.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1503502128334230, "parent_rev":
"09a76193f5fa87bfacefd2ea15249338792aad1d", "commit_rev":
"fd7cffa43366d5fb8a95da71fffa7f872037fefe"}
Message was sent while issue was closed.
Description was changed from ========== Enable -Wunused-lambda-capture warning This should prevent some build errors downstream. The warning is currrently disabled in Chromium: https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?rcl=735aa... (see https://crbug.com/681136 for more info). BUG=webrtc:7133 NOTRY=True ========== to ========== Enable -Wunused-lambda-capture warning This should prevent some build errors downstream. The warning is currrently disabled in Chromium: https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?rcl=735aa... (see https://crbug.com/681136 for more info). BUG=webrtc:7133 NOTRY=True Review-Url: https://codereview.webrtc.org/2999403002 Cr-Commit-Position: refs/heads/master@{#19466} Committed: https://chromium.googlesource.com/external/webrtc/+/fd7cffa43366d5fb8a95da71f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/fd7cffa43366d5fb8a95da71f...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/3007483002/ by kjellander@webrtc.org. The reason for reverting is: Breaks iOS framework builder.. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
